fix: prevent dots from being URL-encoded in userinfo and add tests

Co-authored-by: Byron <63622+Byron@users.noreply.github.com>

Author: Copilot

gix-url/src/lib.rs

@@ -328,8 +328,37 @@ impl Url {
     }
 }
 
+/// Characters that must be percent-encoded in the userinfo component of a URL.
+///
+/// According to RFC 3986, userinfo can contain:
+/// - unreserved characters: `A-Z a-z 0-9 - . _ ~`
+/// - percent-encoded characters
+/// - sub-delims: `! $ & ' ( ) * + , ; =`
+/// - `:`
+///
+/// This encode set encodes everything else, particularly `@` (userinfo delimiter),
+/// `/` `?` `#` (path/query/fragment delimiters), and various other special characters.
+const USERINFO_ENCODE_SET: &percent_encoding::AsciiSet = &percent_encoding::CONTROLS
+    .add(b' ')
+    .add(b'"')
+    .add(b'#')
+    .add(b'%')
+    .add(b'/')
+    .add(b'<')
+    .add(b'>')
+    .add(b'?')
+    .add(b'@')
+    .add(b'[')
+    .add(b'\\')
+    .add(b']')
+    .add(b'^')
+    .add(b'`')
+    .add(b'{')
+    .add(b'|')
+    .add(b'}');
+
 fn percent_encode(s: &str) -> Cow<'_, str> {
-    percent_encoding::utf8_percent_encode(s, percent_encoding::NON_ALPHANUMERIC).into()
+    percent_encoding::utf8_percent_encode(s, USERINFO_ENCODE_SET).into()
 }
 
 /// Serialization

gix-url/tests/fixtures/make_baseline.sh

@@ -52,6 +52,12 @@ done
 tests_windows+=("file://c:/repo")
 tests_windows+=("c:repo")
 
+# Test URLs with dots in usernames (gitbutler issue #11419)
+# Dots should not be percent-encoded in userinfo
+tests+=("ssh://user.name@host/repo")
+tests+=("git://user.name@host/repo")
+tests+=("user.name@host:repo")
+
 tests_unix+=("${tests[@]}")
 tests_windows+=("${tests[@]}")
 

gix-url/tests/url/parse/http.rs

@@ -94,3 +94,27 @@ fn http_missing_path() -> crate::Result {
     assert_url("http://host.xz", url(Scheme::Http, None, "host.xz", None, b"/"))?;
     Ok(())
 }
+
+#[test]
+fn username_with_dot_is_not_percent_encoded() -> crate::Result {
+    assert_url_roundtrip(
+        "http://user.name@example.com/repo",
+        url(Scheme::Http, "user.name", "example.com", None, b"/repo"),
+    )
+}
+
+#[test]
+fn password_with_dot_is_not_percent_encoded() -> crate::Result {
+    assert_url_roundtrip(
+        "http://user:pass.word@example.com/repo",
+        url_with_pass(Scheme::Http, "user", "pass.word", "example.com", None, b"/repo"),
+    )
+}
+
+#[test]
+fn username_and_password_with_dots_are_not_percent_encoded() -> crate::Result {
+    assert_url_roundtrip(
+        "http://user.name:pass.word@example.com/repo",
+        url_with_pass(Scheme::Http, "user.name", "pass.word", "example.com", None, b"/repo"),
+    )
+}

gix-url/tests/url/parse/ssh.rs

@@ -55,6 +55,14 @@ fn with_user_and_without_port() -> crate::Result {
     )
 }
 
+#[test]
+fn username_with_dot_is_not_percent_encoded() -> crate::Result {
+    assert_url_roundtrip(
+        "ssh://user.name@host.xz/.git",
+        url(Scheme::Ssh, "user.name", "host.xz", None, b"/.git"),
+    )
+}
+
 #[test]
 fn with_user_and_port_and_absolute_path() -> crate::Result {
     assert_url_roundtrip(