chore!: drop support for old nodejs versions

Author: matthewrobertson

package-lock.json

@@ -19,14 +19,14 @@
     }
   },
   "dependencies": {
-    "@types/express": "^5.0.0",
-    "body-parser": "^1.18.3",
+    "@types/express": "^5.0.1",
+    "body-parser": "1.20.3",
     "cloudevents": "^8.0.2",
     "express": "^4.21.2",
     "minimist": "^1.2.8",
     "on-finished": "^2.3.0",
-    "read-pkg-up": "^7.0.1",
-    "semver": "^7.6.3"
+    "read-package-up": "^11.0.0",
+    "semver": "^7.7.1"
   },
   "scripts": {
     "test": "mocha build/test --recursive",
@@ -52,21 +52,21 @@
   "author": "Google Inc.",
   "license": "Apache-2.0",
   "devDependencies": {
-    "@microsoft/api-extractor": "^7.48.0",
+    "@microsoft/api-extractor": "^7.52.2",
     "@types/body-parser": "1.19.5",
     "@types/minimist": "1.2.5",
     "@types/mocha": "^10.0.0",
-    "@types/node": "^22.10.1",
+    "@types/node": "^22.13.14",
     "@types/on-finished": "2.3.4",
-    "@types/semver": "^7.5.8",
-    "@types/sinon": "^17.0.3",
-    "@types/supertest": "6.0.2",
-    "gts": "5.3.1",
-    "mocha": "^9.2.2",
-    "nise": "5.1.4",
-    "pack-n-play": "2.0.0",
-    "sinon": "15.0.1",
-    "supertest": "^6.3.4",
-    "typescript": "5.0.3"
+    "@types/semver": "^7.7.0",
+    "@types/sinon": "^17.0.4",
+    "@types/supertest": "6.0.3",
+    "gts": "6.0.2",
+    "mocha": "^11.1 .0",
+    "nise": "6.1.1",
+    "pack-n-play": "3.0.0",
+    "sinon": "20.0.0",
+    "supertest": "^7.1.0",
+    "typescript": "5.8.2"
   }
 }

package.json

@@ -14,7 +14,7 @@ let asyncLocalStorage: AsyncLocalStorage<ExecutionContext> | undefined;
 export async function asyncLocalStorageMiddleware(
   req: Request,
   res: Response,
-  next: NextFunction
+  next: NextFunction,
 ) {
   if (
     semver.lt(process.versions.node, requiredNodeJsVersionForLogExecutionID)
@@ -35,7 +35,7 @@ export async function asyncLocalStorageMiddleware(
     },
     () => {
       next();
-    }
+    },
   );
 }
 

src/async_local_storage.ts

@@ -57,13 +57,13 @@ export function isBinaryCloudEvent(req: express.Request): boolean {
  * @return CloudEvents context
  */
 export function getBinaryCloudEventContext(
-  req: express.Request
+  req: express.Request,
 ): CloudEvent<unknown> {
   const context = {} as CloudEvent<unknown>;
   for (const name in req.headers) {
     if (name.startsWith('ce-')) {
       const attributeName = name.substr(
-        'ce-'.length
+        'ce-'.length,
       ) as keyof CloudEvent<unknown>;
       context[attributeName] = req.header(name);
     }

src/cloud_events.ts

@@ -16,7 +16,7 @@ function generateExecutionId() {
 export const executionContextMiddleware = (
   req: Request,
   res: Response,
-  next: NextFunction
+  next: NextFunction,
 ) => {
   let executionId = req.header(FUNCTION_EXECUTION_ID_HEADER_KEY);
   if (!executionId) {

src/execution_context.ts

@@ -39,7 +39,7 @@ const registrationContainer = new Map<string, RegisteredFunction<any, any>>();
 const register = <T = unknown, U = unknown>(
   functionName: string,
   signatureType: SignatureType,
-  userFunction: HandlerFunction<T, U>
+  userFunction: HandlerFunction<T, U>,
 ): void => {
   if (!isValidFunctionName(functionName)) {
     throw new Error(`Invalid function name: ${functionName}`);
@@ -73,7 +73,7 @@ export const isValidFunctionName = (functionName: string): boolean => {
  * the provided name has been registered
  */
 export const getRegisteredFunction = (
-  functionName: string
+  functionName: string,
   // eslint-disable-next-line @typescript-eslint/no-explicit-any
 ): RegisteredFunction<any, any> | undefined => {
   return registrationContainer.get(functionName);
@@ -97,7 +97,7 @@ export const http = (functionName: string, handler: HttpFunction): void => {
  */
 export const cloudEvent = <T = unknown>(
   functionName: string,
-  handler: CloudEventFunction<T> | CloudEventFunctionWithCallback<T>
+  handler: CloudEventFunction<T> | CloudEventFunctionWithCallback<T>,
 ): void => {
   register(functionName, 'cloudevent', handler);
 };
@@ -110,7 +110,7 @@ export const cloudEvent = <T = unknown>(
  */
 export const typed = <T, U>(
   functionName: string,
-  handler: TypedFunction<T, U>['handler'] | TypedFunction<T, U>
+  handler: TypedFunction<T, U>['handler'] | TypedFunction<T, U>,
 ): void => {
   if (handler instanceof Function) {
     handler = {

src/function_registry.ts

@@ -136,7 +136,7 @@ const wrapHttpFunction = (execute: HttpFunction): RequestHandler => {
  * @return An Express hander function that invokes the user function
  */
 const wrapCloudEventFunction = (
-  userFunction: CloudEventFunction
+  userFunction: CloudEventFunction,
 ): RequestHandler => {
   const httpHandler = (req: Request, res: Response) => {
     const callback = getOnDoneCallback(res);
@@ -145,7 +145,7 @@ const wrapCloudEventFunction = (
       .then(() => userFunction(cloudEvent))
       .then(
         result => callback(null, result),
-        err => callback(err, undefined)
+        err => callback(err, undefined),
       );
   };
   return wrapHttpFunction(httpHandler);
@@ -157,7 +157,7 @@ const wrapCloudEventFunction = (
  * @return An Express hander function that invokes the user function
  */
 const wrapCloudEventFunctionWithCallback = (
-  userFunction: CloudEventFunctionWithCallback
+  userFunction: CloudEventFunctionWithCallback,
 ): RequestHandler => {
   const httpHandler = (req: Request, res: Response) => {
     const callback = getOnDoneCallback(res);
@@ -180,7 +180,7 @@ const wrapEventFunction = (userFunction: EventFunction): RequestHandler => {
       .then(() => userFunction(data, context))
       .then(
         result => callback(null, result),
-        err => callback(err, undefined)
+        err => callback(err, undefined),
       );
   };
   return wrapHttpFunction(httpHandler);
@@ -192,7 +192,7 @@ const wrapEventFunction = (userFunction: EventFunction): RequestHandler => {
  * @return An Express hander function that invokes the user function
  */
 const wrapEventFunctionWithCallback = (
-  userFunction: EventFunctionWithCallback
+  userFunction: EventFunctionWithCallback,
 ): RequestHandler => {
   const httpHandler = (req: Request, res: Response) => {
     const callback = getOnDoneCallback(res);
@@ -210,12 +210,12 @@ const wrapEventFunctionWithCallback = (
 const wrapTypedFunction = (typedFunction: TypedFunction): RequestHandler => {
   const typedHandlerWrapper: HttpFunction = async (
     req: Request,
-    res: Response
+    res: Response,
   ) => {
     let reqTyped: unknown;
     try {
       reqTyped = typedFunction.format.deserializeRequest(
-        new InvocationRequestImpl(req)
+        new InvocationRequestImpl(req),
       );
     } catch (err) {
       sendCrashResponse({
@@ -234,7 +234,7 @@ const wrapTypedFunction = (typedFunction: TypedFunction): RequestHandler => {
     // eslint-disable-next-line @typescript-eslint/no-floating-promises
     typedFunction.format.serializeResponse(
       new InvocationResponseImpl(res),
-      resTyped
+      resTyped,
     );
   };
 
@@ -249,7 +249,7 @@ const wrapTypedFunction = (typedFunction: TypedFunction): RequestHandler => {
  */
 export const wrapUserFunction = <T = unknown>(
   userFunction: HandlerFunction<T>,
-  signatureType: SignatureType
+  signatureType: SignatureType,
 ): RequestHandler => {
   switch (signatureType) {
     case 'http':
@@ -258,15 +258,15 @@ export const wrapUserFunction = <T = unknown>(
       // Callback style if user function has more than 2 arguments.
       if (userFunction instanceof Function && userFunction!.length > 2) {
         return wrapEventFunctionWithCallback(
-          userFunction as EventFunctionWithCallback
+          userFunction as EventFunctionWithCallback,
         );
       }
       return wrapEventFunction(userFunction as EventFunction);
     case 'cloudevent':
       if (userFunction instanceof Function && userFunction!.length > 1) {
         // Callback style if user function has more than 1 argument.
         return wrapCloudEventFunctionWithCallback(
-          userFunction as CloudEventFunctionWithCallback
+          userFunction as CloudEventFunctionWithCallback,
         );
       }
       return wrapCloudEventFunction(userFunction as CloudEventFunction);

src/function_wrappers.ts

@@ -206,7 +206,7 @@ export interface InvocationFormat<T, U> {
    */
   serializeResponse(
     responseWriter: InvocationResponse,
-    response: U
+    response: U,
   ): void | Promise<void>;
 }
 
@@ -225,7 +225,7 @@ export class JsonInvocationFormat<T, U> implements InvocationFormat<T, U> {
     } catch (e) {
       throw new Error(
         'Failed to parse malformatted JSON in request: ' +
-          (e as SyntaxError).message
+          (e as SyntaxError).message,
       );
     }
   }

src/functions.ts

@@ -44,7 +44,7 @@ export function sendResponse(
   // eslint-disable-next-line @typescript-eslint/no-explicit-any
   result: any,
   err: Error | null,
-  res: express.Response
+  res: express.Response,
 ) {
   if (err) {
     sendCrashResponse({err, res, statusHeader: 'error'});
@@ -67,7 +67,7 @@ export function sendResponse(
       // (this was the customer's clear intent) but send a 204 (NO CONTENT) and
       // log an error message explaining why their content wasn't sent.
       console.error(
-        'Error serializing return value: ' + (sendErr as Error).toString()
+        'Error serializing return value: ' + (sendErr as Error).toString(),
       );
       res.sendStatus(204); // No Content
     }

src/invoker.ts

@@ -20,7 +20,6 @@
 
 import * as path from 'path';
 import * as semver from 'semver';
-import * as readPkgUp from 'read-pkg-up';
 import {pathToFileURL} from 'url';
 import {HandlerFunction} from './functions';
 import {SignatureType} from './types';
@@ -56,7 +55,8 @@ async function isEsModule(modulePath: string): Promise<boolean> {
     return false;
   }
 
-  const pkg = await readPkgUp({
+  const {readPackageUp} = await dynamicImport('read-package-up');
+  const pkg = await readPackageUp({
     cwd: path.dirname(modulePath),
     normalize: false,
   });
@@ -73,7 +73,7 @@ async function isEsModule(modulePath: string): Promise<boolean> {
  */
 const dynamicImport = new Function(
   'modulePath',
-  'return import(modulePath)'
+  'return import(modulePath)',
   // eslint-disable-next-line @typescript-eslint/no-explicit-any
 ) as (modulePath: string) => Promise<any>;
 
@@ -85,7 +85,7 @@ const dynamicImport = new Function(
 export async function getUserFunction(
   codeLocation: string,
   functionTarget: string,
-  signatureType: SignatureType
+  signatureType: SignatureType,
 ): Promise<{
   userFunction: HandlerFunction;
   signatureType: SignatureType;
@@ -96,7 +96,7 @@ export async function getUserFunction(
       console.error(
         `Provided code location '${codeLocation}' is not a loadable module.` +
           '\nDid you specify the correct location for the module defining ' +
-          'your function?'
+          'your function?',
       );
       return null;
     }
@@ -107,7 +107,7 @@ export async function getUserFunction(
       if (semver.lt(process.version, MIN_NODE_VERSION_ESMODULES)) {
         console.error(
           `Cannot load ES Module on Node.js ${process.version}. ` +
-            `Please upgrade to Node.js v${MIN_NODE_VERSION_ESMODULES} and up.`
+            `Please upgrade to Node.js v${MIN_NODE_VERSION_ESMODULES} and up.`,
         );
         return null;
       }
@@ -138,15 +138,15 @@ export async function getUserFunction(
     if (typeof userFunction === 'undefined') {
       console.error(
         `Function '${functionTarget}' is not defined in the provided ` +
-          'module.\nDid you specify the correct target function to execute?'
+          'module.\nDid you specify the correct target function to execute?',
       );
       return null;
     }
 
     if (typeof userFunction !== 'function') {
       console.error(
         `'${functionTarget}' needs to be of type function. Got: ` +
-          `${typeof userFunction}`
+          `${typeof userFunction}`,
       );
       return null;
     }
@@ -165,7 +165,7 @@ export async function getUserFunction(
     }
     console.error(
       `Provided module can't be loaded.\n${additionalHint}` +
-        `Detailed stack trace: ${err.stack}`
+        `Detailed stack trace: ${err.stack}`,
     );
     return null;
   }