Skip to content

Commit a49dc10

Browse files
Fixed test
1 parent 8409638 commit a49dc10

File tree

2 files changed

+10
-12
lines changed

2 files changed

+10
-12
lines changed

compute/cloud-client/src/main/java/compute/CreateInstanceWithRegionalDiskFromSnapshot.java

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ public static void main(String[] args) throws IOException, ExecutionException,
6262
}
6363

6464
// Creates a new VM instance with regional disk from a snapshot and specifies replica zones.
65-
public static Instance createInstanceWithRegionalDiskFromSnapshot(
65+
public static Operation.Status createInstanceWithRegionalDiskFromSnapshot(
6666
String projectId, String zone, String instanceName, String diskName,
6767
String diskType, String snapshotLink, List<String> replicaZones)
6868
throws IOException, ExecutionException, InterruptedException, TimeoutException {
@@ -97,14 +97,13 @@ public static Instance createInstanceWithRegionalDiskFromSnapshot(
9797
.addNetworkInterfaces(networkInterface)
9898
.build();
9999

100-
Operation operation = instancesClient.insertAsync(projectId, zone, instanceResource).get(3,
100+
Operation response = instancesClient.insertAsync(projectId, zone, instanceResource).get(3,
101101
TimeUnit.MINUTES);
102102

103-
if (operation.hasError()) {
104-
return null;
103+
if (response.hasError()) {
104+
throw new Error("Error creating instance! " + response.getError());
105105
}
106-
107-
return instancesClient.get(projectId, zone, instanceName);
106+
return response.getStatus();
108107
}
109108
}
110109
}

compute/cloud-client/src/test/java/compute/InstanceOperationsIT.java

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -259,12 +259,11 @@ public void testCreateEncryptedDisk()
259259
@Test
260260
public void testCreateInstanceWithRegionalDiskFromSnapshot()
261261
throws IOException, ExecutionException, InterruptedException, TimeoutException {
262-
Instance instance =
263-
CreateInstanceWithRegionalDiskFromSnapshot.createInstanceWithRegionalDiskFromSnapshot(
264-
PROJECT_ID, ZONE, INSTANCE_NAME, REPLICATED_DISK_NAME,
265-
DISK_TYPE, DISK_SNAPSHOT_LINK, REPLICA_ZONES);
262+
Operation.Status status = CreateInstanceWithRegionalDiskFromSnapshot
263+
.createInstanceWithRegionalDiskFromSnapshot(
264+
PROJECT_ID, ZONE, INSTANCE_NAME, REPLICATED_DISK_NAME,
265+
DISK_TYPE, DISK_SNAPSHOT_LINK, REPLICA_ZONES);
266266

267-
assertThat(instance).isNotNull();
268-
assertThat(instance.getName()).isEqualTo(INSTANCE_NAME);
267+
assertThat(status).isEqualTo(Operation.Status.DONE);
269268
}
270269
}

0 commit comments

Comments
 (0)