Skip to content

Commit df97636

Browse files
Added clean up methods for reservations
1 parent d116264 commit df97636

File tree

5 files changed

+27
-4
lines changed

5 files changed

+27
-4
lines changed

compute/cloud-client/src/test/java/compute/reservation/ConsumeReservationsIT.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@
2929
import com.google.cloud.compute.v1.Reservation;
3030
import com.google.cloud.compute.v1.ReservationsClient;
3131
import compute.DeleteInstance;
32+
import compute.Util;
3233
import java.io.IOException;
3334
import java.util.UUID;
3435
import java.util.concurrent.ExecutionException;
@@ -90,6 +91,10 @@ public static void cleanup()
9091
Assertions.assertThrows(
9192
NotFoundException.class,
9293
() -> GetReservation.getReservation(PROJECT_ID, RESERVATION_NAME, ZONE));
94+
95+
// Clean up stale resources
96+
Util.cleanUpExistingInstances("test-instance-", PROJECT_ID, ZONE);
97+
Util.cleanUpExistingReservations("test-reservation-", PROJECT_ID, ZONE);
9398
}
9499

95100
@Test

compute/cloud-client/src/test/java/compute/reservation/CreateReservationFromVmIT.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -71,10 +71,6 @@ public static void setUp()
7171
instanceForReservation = "test-instance-for-reserv-" + javaVersion + "-"
7272
+ UUID.randomUUID().toString().substring(0, 8);
7373

74-
// Cleanup existing stale resources.
75-
Util.cleanUpExistingInstances("test-instance-for-reserv-" + javaVersion, PROJECT_ID, ZONE);
76-
Util.cleanUpExistingReservations("test-reservation-from-vm-" + javaVersion, PROJECT_ID, ZONE);
77-
7874
CreateInstance.createInstance(PROJECT_ID, ZONE, instanceForReservation);
7975
}
8076

@@ -84,6 +80,10 @@ public static void cleanup()
8480
// Delete resources created for testing.
8581
DeleteInstance.deleteInstance(PROJECT_ID, ZONE, instanceForReservation);
8682

83+
// Clean up stale resources
84+
Util.cleanUpExistingReservations("test-reservation-from-vm-", PROJECT_ID, ZONE);
85+
Util.cleanUpExistingInstances("test-instance-for-reserv-", PROJECT_ID, ZONE);
86+
8787
reservationsClient.close();
8888
instancesClient.close();
8989
}

compute/cloud-client/src/test/java/compute/reservation/CrudOperationsReservationIT.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222

2323
import com.google.api.gax.rpc.NotFoundException;
2424
import com.google.cloud.compute.v1.Reservation;
25+
import compute.Util;
2526
import java.io.IOException;
2627
import java.util.List;
2728
import java.util.UUID;
@@ -69,6 +70,9 @@ public static void cleanup()
6970
Assertions.assertThrows(
7071
NotFoundException.class,
7172
() -> GetReservation.getReservation(PROJECT_ID, RESERVATION_NAME, ZONE));
73+
74+
// Clean up stale resources
75+
Util.cleanUpExistingReservations("test-reservation-", PROJECT_ID, ZONE);
7276
}
7377

7478
@Test

compute/cloud-client/src/test/java/compute/reservation/ReservationIT.java

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@
3636
import compute.CreateRegionalInstanceTemplate;
3737
import compute.DeleteInstanceTemplate;
3838
import compute.DeleteRegionalInstanceTemplate;
39+
import compute.Util;
3940
import java.io.ByteArrayOutputStream;
4041
import java.io.IOException;
4142
import java.io.PrintStream;
@@ -145,6 +146,13 @@ public static void cleanup()
145146
NotFoundException.class,
146147
() -> GetReservation.getReservation(PROJECT_ID, RESERVATION_NAME_REGIONAL, ZONE));
147148

149+
// Clean up stale resources
150+
Util.cleanUpExistingReservations("test-reservation-", PROJECT_ID, ZONE);
151+
Util.cleanUpExistingInstanceTemplates("test-global-inst-temp-", PROJECT_ID);
152+
Util.cleanUpExistingInstanceTemplates("test-shared-inst-temp-", PROJECT_ID);
153+
Util.cleanUpExistingRegionalInstanceTemplates(
154+
"test-regional-inst-temp-", PROJECT_ID, ZONE);
155+
148156
stdOut.close();
149157
System.setOut(out);
150158
}

compute/cloud-client/src/test/java/compute/reservation/WithoutConsumingReservationIT.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
import com.google.cloud.compute.v1.InstanceTemplate;
2424
import compute.DeleteInstance;
2525
import compute.DeleteInstanceTemplate;
26+
import compute.Util;
2627
import java.io.IOException;
2728
import java.util.UUID;
2829
import java.util.concurrent.ExecutionException;
@@ -71,6 +72,11 @@ public static void cleanup()
7172
DeleteInstance.deleteInstance(PROJECT_ID, ZONE, INSTANCE_NOT_CONSUME_RESERVATION_NAME);
7273
DeleteInstanceTemplate.deleteInstanceTemplate(
7374
PROJECT_ID, TEMPLATE_NOT_CONSUME_RESERVATION_NAME);
75+
76+
// Clean up stale resources
77+
Util.cleanUpExistingReservations("test-reservation-", PROJECT_ID, ZONE);
78+
Util.cleanUpExistingInstances("test-instance-not-consume-", PROJECT_ID, ZONE);
79+
Util.cleanUpExistingInstanceTemplates("test-template-not-consume-", PROJECT_ID);
7480
}
7581

7682
@Test

0 commit comments

Comments
 (0)