Skip to content

Commit eeb7fe7

Browse files
authored
chore(bigquery): Remove unused sample code for delete transfer (#13789)
1 parent 0bd8199 commit eeb7fe7

File tree

3 files changed

+5
-30
lines changed

3 files changed

+5
-30
lines changed

bigquery-datatransfer/snippets/conftest.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ def transfer_client(default_credentials, project_id):
123123

124124
@pytest.fixture(scope="session")
125125
def transfer_config_name(transfer_client, project_id, dataset_id, service_account_name):
126-
from . import manage_transfer_configs, scheduled_query
126+
from . import scheduled_query
127127

128128
# Use the transfer_client fixture so we know quota is attributed to the
129129
# correct project.
@@ -140,9 +140,10 @@ def transfer_config_name(transfer_client, project_id, dataset_id, service_accoun
140140
}
141141
)
142142
yield transfer_config.name
143-
manage_transfer_configs.delete_config(
144-
{"transfer_config_name": transfer_config.name}
145-
)
143+
try:
144+
transfer_client.delete_transfer_config(name=transfer_config.name)
145+
except google.api_core.exceptions.NotFound:
146+
pass
146147

147148

148149
@pytest.fixture

bigquery-datatransfer/snippets/manage_transfer_configs.py

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -138,23 +138,3 @@ def schedule_backfill_manual_transfer(override_values={}):
138138
print(f"backfill: {run.run_time} run: {run.name}")
139139
# [END bigquerydatatransfer_schedule_backfill]
140140
return response.runs
141-
142-
143-
def delete_config(override_values={}):
144-
import google.api_core.exceptions
145-
from google.cloud import bigquery_datatransfer
146-
147-
transfer_client = bigquery_datatransfer.DataTransferServiceClient()
148-
149-
transfer_config_name = "projects/1234/locations/us/transferConfigs/abcd"
150-
# To facilitate testing, we replace values with alternatives
151-
# provided by the testing harness.
152-
transfer_config_name = override_values.get(
153-
"transfer_config_name", transfer_config_name
154-
)
155-
try:
156-
transfer_client.delete_transfer_config(name=transfer_config_name)
157-
except google.api_core.exceptions.NotFound:
158-
print("Transfer config not found.")
159-
else:
160-
print(f"Deleted transfer config: {transfer_config_name}")

bigquery-datatransfer/snippets/manage_transfer_configs_test.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -53,9 +53,3 @@ def test_schedule_backfill_manual_transfer(capsys, transfer_config_name):
5353
assert transfer_config_name in out
5454
# Check that there are three runs for between 2 and 5 days ago.
5555
assert len(runs) == 3
56-
57-
58-
def test_delete_config(capsys, transfer_config_name):
59-
# transfer_config_name fixture in conftest.py calls the delete config
60-
# sample. To conserve limited BQ-DTS quota we only make basic checks.
61-
assert len(transfer_config_name) != 0

0 commit comments

Comments
 (0)