Skip to content

Commit f9e3efc

Browse files
Apply code review suggestions to replace "member" with "principal" in additional places (#13071)
* Update modify_policy_remove_member.py Per code review suggestions, replace additional instances of "member" with "principal" * Update modify_policy_add_member.py (#13070)
1 parent af9c528 commit f9e3efc

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

iam/cloud-client/snippets/modify_policy_add_member.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,22 +19,22 @@
1919

2020

2121
def modify_policy_add_member(
22-
project_id: str, role: str, member: str
22+
project_id: str, role: str, principal: str
2323
) -> policy_pb2.Policy:
2424
"""
2525
Add a principal to certain role in project policy.
2626
2727
project_id: ID or number of the Google Cloud project you want to use.
2828
role: role to which principal need to be added.
29-
member: The principal requesting access.
29+
principal: The principal requesting access.
3030
3131
For principal ID formats, see https://cloud.google.com/iam/docs/principal-identifiers
3232
"""
3333
policy = get_project_policy(project_id)
3434

3535
for bind in policy.bindings:
3636
if bind.role == role:
37-
bind.members.append(member)
37+
bind.members.append(principal)
3838
break
3939

4040
return set_project_policy(project_id, policy)
@@ -52,4 +52,4 @@ def modify_policy_add_member(
5252
role = "roles/viewer"
5353
member = f"serviceAccount:test-service-account@{project_id}.iam.gserviceaccount.com"
5454

55-
modify_policy_add_member(project_id, role, member)
55+
modify_policy_add_member(project_id, role, principal)

iam/cloud-client/snippets/modify_policy_remove_member.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,14 +19,14 @@
1919

2020

2121
def modify_policy_remove_member(
22-
project_id: str, role: str, member: str
22+
project_id: str, role: str, principal: str
2323
) -> policy_pb2.Policy:
2424
"""
2525
Remove a principal from certain role in project policy.
2626
2727
project_id: ID or number of the Google Cloud project you want to use.
2828
role: role to revoke.
29-
member: The principal to revoke access from.
29+
principal: The principal to revoke access from.
3030
3131
For principal ID formats, see https://cloud.google.com/iam/docs/principal-identifiers
3232
"""
@@ -35,7 +35,7 @@ def modify_policy_remove_member(
3535
for bind in policy.bindings:
3636
if bind.role == role:
3737
if member in bind.members:
38-
bind.members.remove(member)
38+
bind.members.remove(principal)
3939
break
4040

4141
return set_project_policy(project_id, policy, False)
@@ -51,6 +51,6 @@ def modify_policy_remove_member(
5151
# Your Google Cloud project ID.
5252
project_id = "test-project-id"
5353
role = "roles/viewer"
54-
member = f"serviceAccount:test-service-account@{project_id}.iam.gserviceaccount.com"
54+
principal = f"serviceAccount:test-service-account@{project_id}.iam.gserviceaccount.com"
5555

56-
modify_policy_remove_member(project_id, role, member)
56+
modify_policy_remove_member(project_id, role, principal)

0 commit comments

Comments
 (0)