Skip to content

Commit 3bda83d

Browse files
GouravRusiya30GouravRusiya30
committed
sonarlit changes
1 parent 7c69cad commit 3bda83d

File tree

7 files changed

+31
-29
lines changed

7 files changed

+31
-29
lines changed

src/main/java/com/gourav/restApi/RestApiApplication.java renamed to src/main/java/com/gourav/restapi/RestApiApplication.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
package com.gourav.restApi;
1+
package com.gourav.restapi;
22

33
import org.springframework.boot.SpringApplication;
44
import org.springframework.boot.autoconfigure.SpringBootApplication;

src/main/java/com/gourav/restApi/controllers/PetsController.java renamed to src/main/java/com/gourav/restapi/controllers/PetsController.java

Lines changed: 15 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,48 +1,51 @@
1-
package com.gourav.restApi.controllers;
1+
package com.gourav.restapi.controllers;
22

33
import java.util.List;
44
import javax.validation.Valid;
55
import org.bson.types.ObjectId;
66
import org.springframework.beans.factory.annotation.Autowired;
7+
import org.springframework.web.bind.annotation.GetMapping;
78
import org.springframework.web.bind.annotation.PathVariable;
9+
import org.springframework.web.bind.annotation.PostMapping;
10+
import org.springframework.web.bind.annotation.PutMapping;
811
import org.springframework.web.bind.annotation.RequestBody;
912
import org.springframework.web.bind.annotation.RequestMapping;
1013
import org.springframework.web.bind.annotation.RequestMethod;
1114
import org.springframework.web.bind.annotation.RestController;
12-
import com.gourav.restApi.models.Pets;
13-
import com.gourav.restApi.repositories.PetsRepository;
15+
import com.gourav.restapi.models.Pets;
16+
import com.gourav.restapi.repositories.PetsRepository;
1417

1518
@RestController
1619
@RequestMapping("/pets")
1720
public class PetsController {
1821
@Autowired
1922
private PetsRepository repository;
2023

21-
@RequestMapping(value = "/", method = RequestMethod.GET)
24+
@GetMapping(value = "/")
2225
public List<Pets> getAllPets() {
2326
return repository.findAll();
2427
}
2528

26-
@RequestMapping(value = "/{id}", method = RequestMethod.GET)
29+
@GetMapping(value = "/{id}")
2730
public Pets getPetById(@PathVariable("id") ObjectId id) {
28-
return repository.findBy_id(id);
31+
return repository.findById(id);
2932
}
3033

31-
@RequestMapping(value = "/{id}", method = RequestMethod.PUT)
34+
@PutMapping(value = "/{id}")
3235
public void modifyPetById(@PathVariable("id") ObjectId id, @Valid @RequestBody Pets pets) {
33-
pets.set_id(id);
36+
pets.setId(id);
3437
repository.save(pets);
3538
}
3639

37-
@RequestMapping(value = "/", method = RequestMethod.POST)
40+
@PostMapping(value = "/")
3841
public Pets createPet(@Valid @RequestBody Pets pets) {
39-
pets.set_id(ObjectId.get());
42+
pets.setId(ObjectId.get());
4043
repository.save(pets);
4144
return pets;
4245
}
4346

44-
@RequestMapping(value = "/{id}", method = RequestMethod.DELETE)
47+
@PostMapping(value = "/{id}")
4548
public void deletePet(@PathVariable ObjectId id) {
46-
repository.delete(repository.findBy_id(id));
49+
repository.delete(repository.findById(id));
4750
}
4851
}

src/main/java/com/gourav/restApi/models/Pets.java renamed to src/main/java/com/gourav/restapi/models/Pets.java

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,30 +1,29 @@
1-
package com.gourav.restApi.models;
1+
package com.gourav.restapi.models;
22

33
import org.bson.types.ObjectId;
44
import org.springframework.data.annotation.Id;
55

66
public class Pets {
77

88
@Id
9-
private ObjectId _id;
10-
9+
private ObjectId id;
1110
private String name;
1211
private String species;
1312
private String breed;
1413

1514
// Constructors
1615
public Pets() {}
1716

18-
public Pets(ObjectId _id, String name, String species, String breed) {
19-
this._id = _id;
17+
public Pets(ObjectId id, String name, String species, String breed) {
18+
this.id = id;
2019
this.name = name;
2120
this.species = species;
2221
this.breed = breed;
2322
}
2423

2524
// ObjectId needs to be converted to string
26-
public String get_id() { return _id.toHexString(); }
27-
public void set_id(ObjectId _id) { this._id = _id; }
25+
public String getId() { return id.toHexString(); }
26+
public void setId(ObjectId id) { this.id = id; }
2827

2928
public String getName() { return name; }
3029
public void setName(String name) { this.name = name; }

src/main/java/com/gourav/restApi/repositories/PetsRepository.java renamed to src/main/java/com/gourav/restapi/repositories/PetsRepository.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
1-
package com.gourav.restApi.repositories;
1+
package com.gourav.restapi.repositories;
22

33
import org.bson.types.ObjectId;
44
import org.springframework.data.mongodb.repository.MongoRepository;
5-
import com.gourav.restApi.models.Pets;
5+
import com.gourav.restapi.models.Pets;
66

77
public interface PetsRepository extends MongoRepository<Pets, String> {
8-
Pets findBy_id(ObjectId _id);
8+
Pets findById(ObjectId id);
99
}

src/test/java/com/gourav/restApi/RestApiApplicationTest.java renamed to src/test/java/com/gourav/restapi/RestApiApplicationTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
package com.gourav.restApi;
1+
package com.gourav.restapi;
22

33
import org.junit.Test;
44
import org.junit.runner.RunWith;

src/test/java/com/gourav/restApi/controllers/PetsControllerTest.java renamed to src/test/java/com/gourav/restapi/controllers/PetsControllerTest.java

File renamed without changes.

src/test/java/com/gourav/restApi/models/PetsTest.java renamed to src/test/java/com/gourav/restapi/models/PetsTest.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,18 @@
1-
package com.gourav.restApi.models;
1+
package com.gourav.restapi.models;
22

33
import static org.junit.Assert.*;
44
import org.bson.types.ObjectId;
55
import org.junit.Test;
66

77
public class PetsTest {
88

9-
ObjectId _id = ObjectId.get();
9+
ObjectId id = ObjectId.get();
1010
Pets pets = new Pets();
1111

1212
@Test
13-
public void testSet_id(){
14-
pets.set_id(_id);
15-
assertTrue(pets.get_id().equals(_id.toHexString()));
13+
public void testSetId(){
14+
pets.setId(id);
15+
assertTrue(pets.getId().equals(id.toHexString()));
1616
}
1717

1818
@Test

0 commit comments

Comments
 (0)