From 9481d8f69c2380e2b80e71144d2c8b885215bdb1 Mon Sep 17 00:00:00 2001 From: Abdullah Date: Thu, 8 Jan 2026 18:38:06 +0200 Subject: [PATCH 1/6] Fix enter button not working while focusing on input fields in the new document window --- frontend/src/components/floating-menus/Dialog.svelte | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/frontend/src/components/floating-menus/Dialog.svelte b/frontend/src/components/floating-menus/Dialog.svelte index ce06b22626..d42db5b051 100644 --- a/frontend/src/components/floating-menus/Dialog.svelte +++ b/frontend/src/components/floating-menus/Dialog.svelte @@ -22,6 +22,14 @@ // Focus the button which is marked as emphasized, or otherwise the first button, in the popup const emphasizedOrFirstButton = (self?.div?.()?.querySelector("[data-emphasized]") || self?.div?.()?.querySelector("[data-text-button]") || undefined) as HTMLButtonElement | undefined; emphasizedOrFirstButton?.focus(); + + // Add an event to handle enter press on all focusable fields(inputs) inside the popup + const pop = (self?.div?.()?.querySelector(".layout-col.floating-menu-content") || self?.div?.()?.querySelector("[data-text-button]") || undefined) as HTMLButtonElement | undefined; + pop?.addEventListener("keydown", function (event) { + if (event.key == "Enter") { + emphasizedOrFirstButton?.click(); + } + }) }); From 9bbf242066e7dfe9c6b7dd33f80b664715321ad3 Mon Sep 17 00:00:00 2001 From: Abdullah Date: Fri, 9 Jan 2026 10:12:36 +0200 Subject: [PATCH 2/6] select the pop element using it's data attribute --- frontend/src/components/floating-menus/Dialog.svelte | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/frontend/src/components/floating-menus/Dialog.svelte b/frontend/src/components/floating-menus/Dialog.svelte index d42db5b051..77cc1e6800 100644 --- a/frontend/src/components/floating-menus/Dialog.svelte +++ b/frontend/src/components/floating-menus/Dialog.svelte @@ -24,7 +24,7 @@ emphasizedOrFirstButton?.focus(); // Add an event to handle enter press on all focusable fields(inputs) inside the popup - const pop = (self?.div?.()?.querySelector(".layout-col.floating-menu-content") || self?.div?.()?.querySelector("[data-text-button]") || undefined) as HTMLButtonElement | undefined; + const pop = (self?.div?.()?.querySelector("[data-floating-menu-content]") || self?.div?.()?.querySelector("[data-floating-menu-content]") || undefined) as HTMLButtonElement | undefined; pop?.addEventListener("keydown", function (event) { if (event.key == "Enter") { emphasizedOrFirstButton?.click(); From 60b2521ec121ddeb627bcbfb4abaafa3d3062908 Mon Sep 17 00:00:00 2001 From: Keavon Chambers Date: Sun, 11 Jan 2026 16:51:00 -0800 Subject: [PATCH 3/6] Update frontend/src/components/floating-menus/Dialog.svelte Co-authored-by: Timon --- frontend/src/components/floating-menus/Dialog.svelte | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/frontend/src/components/floating-menus/Dialog.svelte b/frontend/src/components/floating-menus/Dialog.svelte index 77cc1e6800..6d0e94e82a 100644 --- a/frontend/src/components/floating-menus/Dialog.svelte +++ b/frontend/src/components/floating-menus/Dialog.svelte @@ -29,7 +29,7 @@ if (event.key == "Enter") { emphasizedOrFirstButton?.click(); } - }) + }); }); From 130c295564b5564e9610326a547bb5af0395baa1 Mon Sep 17 00:00:00 2001 From: Abdullah Date: Mon, 12 Jan 2026 10:42:21 +0200 Subject: [PATCH 4/6] Use meaningful variable names --- frontend/src/components/floating-menus/Dialog.svelte | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/frontend/src/components/floating-menus/Dialog.svelte b/frontend/src/components/floating-menus/Dialog.svelte index 6d0e94e82a..80c5adfcd8 100644 --- a/frontend/src/components/floating-menus/Dialog.svelte +++ b/frontend/src/components/floating-menus/Dialog.svelte @@ -24,7 +24,7 @@ emphasizedOrFirstButton?.focus(); // Add an event to handle enter press on all focusable fields(inputs) inside the popup - const pop = (self?.div?.()?.querySelector("[data-floating-menu-content]") || self?.div?.()?.querySelector("[data-floating-menu-content]") || undefined) as HTMLButtonElement | undefined; + const floatingMenu = (self?.div?.()?.querySelector("[data-floating-menu-content]") || self?.div?.()?.querySelector("[data-floating-menu-content]") || undefined) as HTMLButtonElement | undefined; pop?.addEventListener("keydown", function (event) { if (event.key == "Enter") { emphasizedOrFirstButton?.click(); From ab0a7d1de14946c0294c4a8bcc4c9c75e1bfec4c Mon Sep 17 00:00:00 2001 From: Abdullah Date: Mon, 12 Jan 2026 10:49:41 +0200 Subject: [PATCH 5/6] small fix in variable names --- frontend/src/components/floating-menus/Dialog.svelte | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/frontend/src/components/floating-menus/Dialog.svelte b/frontend/src/components/floating-menus/Dialog.svelte index 80c5adfcd8..653d898e6e 100644 --- a/frontend/src/components/floating-menus/Dialog.svelte +++ b/frontend/src/components/floating-menus/Dialog.svelte @@ -25,7 +25,7 @@ // Add an event to handle enter press on all focusable fields(inputs) inside the popup const floatingMenu = (self?.div?.()?.querySelector("[data-floating-menu-content]") || self?.div?.()?.querySelector("[data-floating-menu-content]") || undefined) as HTMLButtonElement | undefined; - pop?.addEventListener("keydown", function (event) { + floatingMenu?.addEventListener("keydown", function (event) { if (event.key == "Enter") { emphasizedOrFirstButton?.click(); } From 07d6a0d48e6162d34bd2524d48def4815e8b8411 Mon Sep 17 00:00:00 2001 From: Abdullah Date: Mon, 12 Jan 2026 15:56:56 +0200 Subject: [PATCH 6/6] remove redundant extra selector set on failure --- frontend/src/components/floating-menus/Dialog.svelte | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/frontend/src/components/floating-menus/Dialog.svelte b/frontend/src/components/floating-menus/Dialog.svelte index 653d898e6e..e9d30dae68 100644 --- a/frontend/src/components/floating-menus/Dialog.svelte +++ b/frontend/src/components/floating-menus/Dialog.svelte @@ -24,7 +24,7 @@ emphasizedOrFirstButton?.focus(); // Add an event to handle enter press on all focusable fields(inputs) inside the popup - const floatingMenu = (self?.div?.()?.querySelector("[data-floating-menu-content]") || self?.div?.()?.querySelector("[data-floating-menu-content]") || undefined) as HTMLButtonElement | undefined; + const floatingMenu = (self?.div?.()?.querySelector("[data-floating-menu-content]") || undefined) as HTMLDivElement | undefined; floatingMenu?.addEventListener("keydown", function (event) { if (event.key == "Enter") { emphasizedOrFirstButton?.click();