Skip to content

Commit 9734136

Browse files
committed
get rid of old field display template
1 parent 5cef3da commit 9734136

File tree

7 files changed

+11
-105
lines changed

7 files changed

+11
-105
lines changed

bundles/org.zikula.modulestudio.generator/src/org/zikula/modulestudio/generator/cartridges/symfony/controller/config/ConfigureFields.xtend

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -344,6 +344,9 @@ class ConfigureFields implements ControllerMethodInterface {
344344
// setRoundingMode()
345345
// setThousandsSeparator()
346346
}
347+
if (entity.geographical && #['latitude', 'longitude'].contains(name)) {
348+
calls += '''->setTemplatePath('@EasyAdmin/crud/field/geo.html.twig')'''
349+
}
347350
calls
348351
}
349352

@@ -452,6 +455,7 @@ class ConfigureFields implements ControllerMethodInterface {
452455
def private dispatch options(UserField it) {
453456
var calls = commonOptions
454457
calls += '''->autocomplete()'''
458+
calls += '''->setTemplatePath('@EasyAdmin/crud/field/user.html.twig')'''
455459
// TODO association options
456460
calls
457461
}

bundles/org.zikula.modulestudio.generator/src/org/zikula/modulestudio/generator/cartridges/symfony/view/Plugins.xtend

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ package org.zikula.modulestudio.generator.cartridges.symfony.view
33
import de.guite.modulestudio.metamodel.Application
44
import org.zikula.modulestudio.generator.application.IMostFileSystemAccess
55
import org.zikula.modulestudio.generator.application.ImportList
6-
import org.zikula.modulestudio.generator.cartridges.symfony.view.plugin.FormatGeoData
76
import org.zikula.modulestudio.generator.cartridges.symfony.view.plugin.GetFormattedEntityTitle
87
import org.zikula.modulestudio.generator.cartridges.symfony.view.plugin.GetListEntry
98
import org.zikula.modulestudio.generator.cartridges.symfony.view.plugin.GetLogDescription
@@ -128,9 +127,6 @@ class Plugins {
128127
if (hasListFields) {
129128
result += new GetListEntry().generate(it)
130129
}
131-
if (hasGeographical) {
132-
result += new FormatGeoData().generate(it)
133-
}
134130
if (hasTrees) {
135131
result += new TreeData().generate(it)
136132
result += new TreeSelection().generate(it)

bundles/org.zikula.modulestudio.generator/src/org/zikula/modulestudio/generator/cartridges/symfony/view/pagecomponents/SimpleFields.xtend

Lines changed: 0 additions & 62 deletions
This file was deleted.

bundles/org.zikula.modulestudio.generator/src/org/zikula/modulestudio/generator/cartridges/symfony/view/pages/Detail.xtend

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ import de.guite.modulestudio.metamodel.Relationship
99
import org.zikula.modulestudio.generator.application.IMostFileSystemAccess
1010
import org.zikula.modulestudio.generator.cartridges.symfony.view.pagecomponents.MenuViews
1111
import org.zikula.modulestudio.generator.cartridges.symfony.view.pagecomponents.Relations
12-
import org.zikula.modulestudio.generator.cartridges.symfony.view.pagecomponents.SimpleFields
1312
import org.zikula.modulestudio.generator.extensions.ControllerExtensions
1413
import org.zikula.modulestudio.generator.extensions.FormattingExtensions
1514
import org.zikula.modulestudio.generator.extensions.ModelBehaviourExtensions
@@ -194,9 +193,8 @@ class Detail {
194193
<dd>«displayEntryImpl»</dd>
195194
'''
196195
197-
def private displayEntryImpl(Field it) {
198-
new SimpleFields().displayField(it, entity.name.formatForCode, 'detail')
199-
}
196+
def private displayEntryImpl(Field it) '''
197+
{{ «entity.name.formatForCode».«name.formatForCode» }}'''
200198
201199
def private displayEntry(Relationship it, Boolean useTarget) '''
202200
«val relationAliasName = getRelationAliasName(useTarget).formatForCode»

bundles/org.zikula.modulestudio.generator/src/org/zikula/modulestudio/generator/cartridges/symfony/view/pages/view/ViewTable.xtend

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ import java.util.List
1313
import org.zikula.modulestudio.generator.application.IMostFileSystemAccess
1414
import org.zikula.modulestudio.generator.cartridges.symfony.view.pagecomponents.IndexPagesHelper
1515
import org.zikula.modulestudio.generator.cartridges.symfony.view.pagecomponents.MenuViews
16-
import org.zikula.modulestudio.generator.cartridges.symfony.view.pagecomponents.SimpleFields
1716
import org.zikula.modulestudio.generator.extensions.ControllerExtensions
1817
import org.zikula.modulestudio.generator.extensions.FormattingExtensions
1918
import org.zikula.modulestudio.generator.extensions.ModelBehaviourExtensions
@@ -32,7 +31,6 @@ class ViewTable {
3231
extension UrlExtensions = new UrlExtensions
3332
extension Utils = new Utils
3433

35-
SimpleFields fieldHelper = new SimpleFields
3634
String appName
3735

3836
def generate(Entity it, String appName, IMostFileSystemAccess fsa) {
@@ -200,18 +198,14 @@ class ViewTable {
200198
}
201199
202200
def private dispatch displayEntryInner(Field it, Boolean useTarget) '''
203-
«IF #['name', 'title'].contains(name)»
204-
«IF entity.hasDetailAction»
205-
<a href="{{ path('«application.appName.formatForDB»_«entity.name.formatForDB»_detail'«entity.routeParams(entity.name.formatForCode, true)») }}" title="{{ 'View detail page'|trans({}, 'messages')|e('html_attr') }}">«displayLeadingEntry»</a>
206-
«ELSE»
207-
«displayLeadingEntry»
208-
«ENDIF»
201+
«IF entity.hasDetailAction && #['name', 'title'].contains(name)»
202+
<a href="{{ path('«application.appName.formatForDB»_«entity.name.formatForDB»_detail'«entity.routeParams(entity.name.formatForCode, true)») }}" title="{{ 'View detail page'|trans({}, 'messages')|e('html_attr') }}">«displayField»</a>
209203
«ELSE»
210-
«fieldHelper.displayField(it, entity.name.formatForCode, 'index')»
204+
«displayField»
211205
«ENDIF»
212206
'''
213207
214-
def private displayLeadingEntry(Field it) {
208+
def private displayField(Field it) {
215209
'''{{ «entity.name.formatForCode».«name.formatForCode» }}'''
216210
}
217211

bundles/org.zikula.modulestudio.generator/src/org/zikula/modulestudio/generator/cartridges/symfony/view/plugin/FormatGeoData.xtend

Lines changed: 0 additions & 24 deletions
This file was deleted.

bundles/org.zikula.modulestudio.generator/src/org/zikula/modulestudio/generator/extensions/ViewExtensions.xtend

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ class ViewExtensions {
7979
«IF 'index' == actionName»
8080
<div id="geographicalInfo" class="d-none" data-context="«actionName»" data-object-type="«objName»" data-tile-layer-url="{{ geoConfig.tile_layer_url|e('html_attr') }}" data-tile-layer-attribution="{{ geoConfig.tile_layer_attribution|e('html_attr') }}"></div>
8181
«ELSE»
82-
<div id="geographicalInfo" class="d-none" data-context="«actionName»" data-latitude="{{ «objName».latitude|«application.appName.formatForDB»_geoData }}" data-longitude="{{ «objName».longitude|«application.appName.formatForDB»_geoData }}" data-zoom-level="{{ geoConfig.default_zoom_level|e('html_attr') }}" data-tile-layer-url="{{ geoConfig.tile_layer_url|e('html_attr') }}" data-tile-layer-attribution="{{ geoConfig.tile_layer_attribution|e('html_attr') }}"«IF actionName == 'edit'» data-use-geolocation="{% if mode == 'create' and geoConfig.enable_«name.formatForSnakeCase»_geo_location %}true{% else %}false{% endif %}"«ENDIF»></div>
82+
<div id="geographicalInfo" class="d-none" data-context="«actionName»" data-latitude="{{ «objName».latitude|formatCoordinate }}" data-longitude="{{ «objName».longitude|formatCoordinate }}" data-zoom-level="{{ geoConfig.default_zoom_level|e('html_attr') }}" data-tile-layer-url="{{ geoConfig.tile_layer_url|e('html_attr') }}" data-tile-layer-attribution="{{ geoConfig.tile_layer_attribution|e('html_attr') }}"«IF actionName == 'edit'» data-use-geolocation="{% if mode == 'create' and geoConfig.enable_«name.formatForSnakeCase»_geo_location %}true{% else %}false{% endif %}"«ENDIF»></div>
8383
«ENDIF»
8484

8585
'''

0 commit comments

Comments
 (0)