Skip to content

Commit 7325b36

Browse files
authored
fix(i18n): improve mod update dialog text (#4788)
fix #4773
1 parent 6fa6f23 commit 7325b36

File tree

12 files changed

+30
-22
lines changed

12 files changed

+30
-22
lines changed

HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/ModCheckUpdatesTask.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,13 +39,13 @@ public ModCheckUpdatesTask(String gameVersion, Collection<LocalModFile> mods) {
3939
.map(type ->
4040
Task.supplyAsync(() -> mod.checkUpdates(gameVersion, type.getRemoteModRepository()))
4141
.setSignificance(TaskSignificance.MAJOR)
42-
.setName(String.format("%s (%s)", mod.getFileName(), type.name())).withCounter("mods.check_updates")
42+
.setName(String.format("%s (%s)", mod.getFileName(), type.name())).withCounter("update.checking")
4343
)
4444
.collect(Collectors.toList())
4545
)
4646
.collect(Collectors.toList());
4747

48-
setStage("mods.check_updates");
48+
setStage("update.checking");
4949
getProperties().put("total", dependents.size() * RemoteMod.Type.values().length);
5050
}
5151

HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/ModListPage.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -247,8 +247,8 @@ public void checkUpdates() {
247247
Controllers.navigateForward(new ModUpdatesPage(modManager, result));
248248
}
249249
})
250-
.withStagesHint(Collections.singletonList("mods.check_updates")),
251-
i18n("update.checking"), TaskCancellationAction.NORMAL);
250+
.withStagesHint(Collections.singletonList("update.checking")),
251+
i18n("mods.check_updates"), TaskCancellationAction.NORMAL);
252252

253253
if (profile.getRepository().isModpack(instanceId)) {
254254
Controllers.confirm(

HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/ModListPageSkin.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,7 @@ final class ModListPageSkin extends SkinBase<ModListPage> {
151151
createToolbarButton2(i18n("button.refresh"), SVG.REFRESH, skinnable::refresh),
152152
createToolbarButton2(i18n("mods.add"), SVG.ADD, skinnable::add),
153153
createToolbarButton2(i18n("button.reveal_dir"), SVG.FOLDER_OPEN, skinnable::openModFolder),
154-
createToolbarButton2(i18n("mods.check_updates"), SVG.UPDATE, skinnable::checkUpdates),
154+
createToolbarButton2(i18n("mods.check_updates.button"), SVG.UPDATE, skinnable::checkUpdates),
155155
createToolbarButton2(i18n("download"), SVG.DOWNLOAD, skinnable::download),
156156
createToolbarButton2(i18n("search"), SVG.SEARCH, () -> changeToolbar(searchBar))
157157
);

HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/ModUpdatesPage.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ public ModUpdatesPage(ModManager modManager, List<LocalModFile.ModUpdate> update
111111
JFXButton exportListButton = FXUtils.newRaisedButton(i18n("button.export"));
112112
exportListButton.setOnAction(e -> exportList());
113113

114-
JFXButton nextButton = FXUtils.newRaisedButton(i18n("mods.check_updates.update"));
114+
JFXButton nextButton = FXUtils.newRaisedButton(i18n("mods.check_updates.confirm"));
115115
nextButton.setOnAction(e -> updateMods());
116116

117117
JFXButton cancelButton = FXUtils.newRaisedButton(i18n("button.cancel"));
@@ -147,7 +147,7 @@ private void updateMods() {
147147
Controllers.dialog(i18n("install.success"));
148148
}
149149
}),
150-
i18n("mods.check_updates.update"),
150+
i18n("mods.check_updates"),
151151
TaskCancellationAction.NORMAL);
152152
}
153153

@@ -276,7 +276,7 @@ public static class ModUpdateTask extends Task<Void> {
276276
private final List<LocalModFile> failedMods = new ArrayList<>();
277277

278278
ModUpdateTask(ModManager modManager, List<Pair<LocalModFile, RemoteMod.Version>> mods) {
279-
setStage("mods.check_updates.update");
279+
setStage("mods.check_updates.confirm");
280280
getProperties().put("total", mods.size());
281281

282282
this.dependents = new ArrayList<>();
@@ -308,7 +308,7 @@ public static class ModUpdateTask extends Task<Void> {
308308
failedMods.add(local);
309309
}
310310
})
311-
.withCounter("mods.check_updates.update"));
311+
.withCounter("mods.check_updates.confirm"));
312312
}
313313
}
314314

HMCL/src/main/resources/assets/lang/I18N.properties

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1059,15 +1059,16 @@ mods.category=Category
10591059
mods.channel.alpha=Alpha
10601060
mods.channel.beta=Beta
10611061
mods.channel.release=Release
1062-
mods.check_updates=Update
1062+
mods.check_updates=Mod update process
1063+
mods.check_updates.button=Update
1064+
mods.check_updates.confirm=Update
10631065
mods.check_updates.current_version=Current Version
10641066
mods.check_updates.empty=All mods are up-to-date
10651067
mods.check_updates.failed_check=Failed to check for updates.
10661068
mods.check_updates.failed_download=Failed to download some files.
10671069
mods.check_updates.file=File
10681070
mods.check_updates.source=Source
10691071
mods.check_updates.target_version=Target Version
1070-
mods.check_updates.update=Update
10711072
mods.choose_mod=Choose mod
10721073
mods.curseforge=CurseForge
10731074
mods.dependency.embedded=Built-in Dependencies (Already packaged in the mod file by the author. No need to download separately)
@@ -1519,7 +1520,7 @@ update.channel.nightly.hint=You are currently using a Nightly channel build of t
15191520
Follow <a href="https://space.bilibili.com/1445341">@huanghongxun</a> on Bilibili to stay up to date on important HMCL news, or <a href="https://space.bilibili.com/20314891">@Glavo</a> to learn about HMCL development progress.
15201521
update.channel.nightly.title=Nightly Channel Notice
15211522
update.channel.stable=Release
1522-
update.checking=Checking for Updates
1523+
update.checking=Checking for updates
15231524
update.failed=Failed to update
15241525
update.found=Update Available!
15251526
update.newest_version=Latest version: %s

HMCL/src/main/resources/assets/lang/I18N_es.properties

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1062,15 +1062,16 @@ mods.category=Categoría
10621062
mods.channel.alpha=Alpha
10631063
mods.channel.beta=Beta
10641064
mods.channel.release=Release
1065-
mods.check_updates=Actualizar
1065+
mods.check_updates=Proceso de actualización de mods
1066+
mods.check_updates.button=Actualizar
1067+
mods.check_updates.confirm=Actualizar
10661068
mods.check_updates.current_version=Versión actual
10671069
mods.check_updates.empty=Todos los mods están actualizados
10681070
mods.check_updates.failed_check=No se ha podido comprobar si hay actualizaciones.
10691071
mods.check_updates.failed_download=No se han podido descargar algunos de los archivos.
10701072
mods.check_updates.file=Archivo
10711073
mods.check_updates.source=Fuente
10721074
mods.check_updates.target_version=Versión de destino
1073-
mods.check_updates.update=Actualización
10741075
mods.choose_mod=Elige un mod
10751076
mods.curseforge=CurseForge
10761077
mods.dependency.embedded=Dependencias incorporadas (Already packaged in the mod file by the author. No need to download separately)

HMCL/src/main/resources/assets/lang/I18N_ja.properties

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -670,13 +670,14 @@ mods.add.failed=mods %s の追加に失敗しました。
670670
mods.add.success=mods %s が正常に追加されました。
671671
mods.category=Category
672672
mods.check_updates=更新を確認
673+
mods.check_updates.button=更新
674+
mods.check_updates.confirm=更新
673675
mods.check_updates.current_version=Current
674676
mods.check_updates.failed_check=更新のチェックに失敗しました
675677
mods.check_updates.failed_download=一部のファイルのダウンロードに失敗しました
676678
mods.check_updates.file=ファイル
677679
mods.check_updates.source=Source
678680
mods.check_updates.target_version=Target
679-
mods.check_updates.update=更新
680681
mods.choose_mod=modを選択してください
681682
mods.curseforge=CurseForge
682683
mods.disable=無効にする

HMCL/src/main/resources/assets/lang/I18N_lzh.properties

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -861,14 +861,15 @@ mods.channel.alpha=預版
861861
mods.channel.beta=試版
862862
mods.channel.release=當版
863863
mods.check_updates=檢改囊之新
864+
mods.check_updates.button=檢改囊之新
865+
mods.check_updates.confirm=迭更
864866
mods.check_updates.current_version=當版
865867
mods.check_updates.empty=無改囊可迭更
866868
mods.check_updates.failed_check=檢囊迭更未成
867869
mods.check_updates.failed_download=有引案未成
868870
mods.check_updates.file=
869871
mods.check_updates.source=
870872
mods.check_updates.target_version=將至之版
871-
mods.check_updates.update=迭更
872873
mods.choose_mod=擇改囊
873874
mods.curseforge=CurseForge
874875
mods.dependency.embedded=既存之相依改囊 (既以內於改囊案,無須他引)

HMCL/src/main/resources/assets/lang/I18N_ru.properties

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1058,14 +1058,15 @@ mods.channel.alpha=Альфа
10581058
mods.channel.beta=Бета
10591059
mods.channel.release=Релиз
10601060
mods.check_updates=Проверить обновления
1061+
mods.check_updates.button=Обновить
1062+
mods.check_updates.confirm=Обновить
10611063
mods.check_updates.current_version=Текущая версия
10621064
mods.check_updates.empty=Все моды новейшие
10631065
mods.check_updates.failed_check=Не удалось проверить обновления.
10641066
mods.check_updates.failed_download=Не удалось скачать некоторые файлы.
10651067
mods.check_updates.file=Файл
10661068
mods.check_updates.source=Источник
10671069
mods.check_updates.target_version=Целевая версия
1068-
mods.check_updates.update=Обновить
10691070
mods.choose_mod=Выберите мод
10701071
mods.curseforge=CurseForge
10711072
mods.dependency.embedded=Встроенные зависимости (Уже упакован в файл мода автором. Нет необходимости скачивать отдельно.)

HMCL/src/main/resources/assets/lang/I18N_uk.properties

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1000,14 +1000,15 @@ mods.channel.alpha=Альфа
10001000
mods.channel.beta=Бета
10011001
mods.channel.release=Реліз
10021002
mods.check_updates=Перевірити оновлення
1003+
mods.check_updates.confirm=Оновити
1004+
mods.check_updates.button=Оновити
10031005
mods.check_updates.current_version=Поточна версія
10041006
mods.check_updates.empty=Усі моди оновлені
10051007
mods.check_updates.failed_check=Не вдалося перевірити оновлення.
10061008
mods.check_updates.failed_download=Не вдалося завантажити деякі файли.
10071009
mods.check_updates.file=Файл
10081010
mods.check_updates.source=Джерело
10091011
mods.check_updates.target_version=Цільова версія
1010-
mods.check_updates.update=Оновити
10111012
mods.choose_mod=Вибрати мод
10121013
mods.curseforge=CurseForge
10131014
mods.dependency.embedded=Вбудовані залежності (Вже запаковані в файл мода автором. Не потрібно завантажувати окремо)

0 commit comments

Comments
 (0)