Skip to content

Commit 0882eb0

Browse files
committed
log stack trace when finish() or onDestroy() is called
Some supurious calls to these functions when tests are still running are observed. Add more logging to see what's the caller. Change-Id: I9254c3639bcb8619be39bfbc6981fae5bf5e7efa
1 parent 89dea78 commit 0882eb0

File tree

1 file changed

+13
-1
lines changed

1 file changed

+13
-1
lines changed

tests/DumpRenderTree/src/com/android/dumprendertree/TestShellActivity.java

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -286,11 +286,23 @@ protected void onStop() {
286286
mWebView.stopLoading();
287287
}
288288

289+
290+
//TODO: remove. this is temporary for bug investigation
291+
@Override
292+
public void finish() {
293+
Exception e = new Exception("finish() call stack");
294+
Log.d(LOGTAG, "finish stack trace", e);
295+
super.finish();
296+
}
297+
289298
@Override
290299
protected void onDestroy() {
291-
super.onDestroy();
300+
//TODO: remove exception log. this is temporary for bug investigation
301+
Exception e = new Exception("onDestroy stack trace");
302+
Log.d(LOGTAG, "onDestroy stack trace", e);
292303
mWebView.destroy();
293304
mWebView = null;
305+
super.onDestroy();
294306
}
295307

296308
@Override

0 commit comments

Comments
 (0)