Skip to content

Commit 095b098

Browse files
author
The Android Automerger
committed
Revert "Fix regression in CursorWindow.getString()"
This reverts commit 715311f.
1 parent 8c01cb5 commit 095b098

File tree

1 file changed

+2
-8
lines changed

1 file changed

+2
-8
lines changed

core/jni/android_database_CursorWindow.cpp

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -205,14 +205,8 @@ static jstring nativeGetString(JNIEnv* env, jclass clazz, jint windowPtr,
205205
if (type == FIELD_TYPE_STRING) {
206206
uint32_t size = fieldSlot->data.buffer.size;
207207
#if WINDOW_STORAGE_UTF8
208-
if (size <= 1) {
209-
return gEmptyString;
210-
}
211-
// Convert to UTF-16 here instead of calling NewStringUTF. NewStringUTF
212-
// doesn't like UTF-8 strings with high codepoints. It actually expects
213-
// Modified UTF-8 with encoded surrogate pairs.
214-
String16 utf16(window->getFieldSlotValueString(fieldSlot), size - 1);
215-
return env->NewString(reinterpret_cast<const jchar*>(utf16.string()), utf16.size());
208+
return size > 1 ? env->NewStringUTF(window->getFieldSlotValueString(fieldSlot))
209+
: gEmptyString;
216210
#else
217211
size_t chars = size / sizeof(char16_t);
218212
return chars ? env->NewString(reinterpret_cast<jchar*>(

0 commit comments

Comments
 (0)