Skip to content

Commit 0d7da09

Browse files
Jeff BrownAndroid (Google) Code Review
authored andcommitted
Merge "Don't load keyboard layout overlay for virtual keyboard."
2 parents cada1ae + 61c0824 commit 0d7da09

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

services/input/EventHub.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1465,6 +1465,8 @@ void EventHub::dump(String8& dump) {
14651465
device->keyMap.keyCharacterMapFile.string());
14661466
dump.appendFormat(INDENT3 "ConfigurationFile: %s\n",
14671467
device->configurationFile.string());
1468+
dump.appendFormat(INDENT3 "HaveKeyboardLayoutOverlay: %s\n",
1469+
toString(device->overlayKeyMap != NULL));
14681470
}
14691471
} // release lock
14701472
}

services/input/InputReader.cpp

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -963,10 +963,12 @@ void InputDevice::configure(nsecs_t when, const InputReaderConfiguration* config
963963
}
964964

965965
if (!changes || (changes & InputReaderConfiguration::CHANGE_KEYBOARD_LAYOUTS)) {
966-
sp<KeyCharacterMap> keyboardLayout =
967-
mContext->getPolicy()->getKeyboardLayoutOverlay(mIdentifier.descriptor);
968-
if (mContext->getEventHub()->setKeyboardLayoutOverlay(mId, keyboardLayout)) {
969-
bumpGeneration();
966+
if (!(mClasses & INPUT_DEVICE_CLASS_VIRTUAL)) {
967+
sp<KeyCharacterMap> keyboardLayout =
968+
mContext->getPolicy()->getKeyboardLayoutOverlay(mIdentifier.descriptor);
969+
if (mContext->getEventHub()->setKeyboardLayoutOverlay(mId, keyboardLayout)) {
970+
bumpGeneration();
971+
}
970972
}
971973
}
972974

0 commit comments

Comments
 (0)