Fix NPE in isPrivateBrowsingEnabled()

Michael Kolb · Michael Kolb · commit 13d7c03eb8e8 · 2012-04-26T10:43:08.000-07:00
Bug: 6393286

Change-Id: I1fd9c57b7bd68a9c495cbb0df45a406f83b22b5f
diff --git a/core/java/android/webkit/WebViewClassic.java b/core/java/android/webkit/WebViewClassic.java
@@ -2598,7 +2598,8 @@ private void goBackOrForward(int steps, boolean ignoreSnapshot) {
      */
     @Override
     public boolean isPrivateBrowsingEnabled() {
-        return getSettings().isPrivateBrowsingEnabled();
+        WebSettingsClassic settings = getSettings();
+        return (settings != null) ? settings.isPrivateBrowsingEnabled() : false;
     }
 
     private void startPrivateBrowsing() {

Original file line number	Diff line number	Diff line change
`@@ -2598,7 +2598,8 @@ private void goBackOrForward(int steps, boolean ignoreSnapshot) {`
`2598`	`2598`	`*/`
`2599`	`2599`	`@Override`
`2600`	`2600`	`public boolean isPrivateBrowsingEnabled() {`
`2601`		`- return getSettings().isPrivateBrowsingEnabled();`
	`2601`	`+ WebSettingsClassic settings = getSettings();`
	`2602`	`+ return (settings != null) ? settings.isPrivateBrowsingEnabled() : false;`
`2602`	`2603`	`}`
`2603`	`2604`
`2604`	`2605`	`private void startPrivateBrowsing() {`