Skip to content

Commit 14c4669

Browse files
committed
Cannot force a shown item from an ActionMode into the overflow menu.
1. An app showing an action mode with a visible item that decides to move this item to the overflow menu cannot do so since the action menu is not updated properly. Specifically, ActionMenuPresenter does not clear the "is action button" property of a menu item neither requires nor requests an action button, i.e. the item's "show as action" property changed to be never shown on the action bar. bug:7319766 Change-Id: I5cfda6269466fafca1f039a3bab6397392ae9f17
1 parent 3b9e7f3 commit 14c4669

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

core/java/com/android/internal/view/menu/ActionMenuPresenter.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -476,6 +476,9 @@ public boolean flagActionItems() {
476476
if (isAction) maxActions--;
477477

478478
item.setIsActionButton(isAction);
479+
} else {
480+
// Neither requires nor requests an action button.
481+
item.setIsActionButton(false);
479482
}
480483
}
481484
return true;

0 commit comments

Comments
 (0)