Skip to content

Commit 1c87360

Browse files
jsharkeyAndroid (Google) Code Review
authored andcommitted
Merge "Make fixed-width dialogs larger on sw600dp." into jb-dev
2 parents 6098c1f + cc15256 commit 1c87360

File tree

2 files changed

+16
-2
lines changed

2 files changed

+16
-2
lines changed

core/res/res/values-sw600dp/dimens.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,10 +64,10 @@
6464

6565
<!-- The platform's desired fixed width for a dialog along the major axis
6666
(the screen is in landscape). This may be either a fraction or a dimension.-->
67-
<item type="dimen" name="dialog_fixed_width_major">50%</item>
67+
<item type="dimen" name="dialog_fixed_width_major">60%</item>
6868
<!-- The platform's desired fixed width for a dialog along the minor axis
6969
(the screen is in portrait). This may be either a fraction or a dimension.-->
70-
<item type="dimen" name="dialog_fixed_width_minor">70%</item>
70+
<item type="dimen" name="dialog_fixed_width_minor">90%</item>
7171
<!-- The platform's desired fixed height for a dialog along the major axis
7272
(the screen is in portrait). This may be either a fraction or a dimension.-->
7373
<item type="dimen" name="dialog_fixed_height_major">60%</item>

core/res/res/values-sw720dp/dimens.xml

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,20 @@
2020
<!-- Height of the bottom navigation bar in portrait; on sw720dp devices
2121
this is the same as the height in landscape -->
2222
<dimen name="navigation_bar_height_portrait">@dimen/navigation_bar_height</dimen>
23+
24+
<!-- The platform's desired fixed width for a dialog along the major axis
25+
(the screen is in landscape). This may be either a fraction or a dimension.-->
26+
<item type="dimen" name="dialog_fixed_width_major">50%</item>
27+
<!-- The platform's desired fixed width for a dialog along the minor axis
28+
(the screen is in portrait). This may be either a fraction or a dimension.-->
29+
<item type="dimen" name="dialog_fixed_width_minor">70%</item>
30+
<!-- The platform's desired fixed height for a dialog along the major axis
31+
(the screen is in portrait). This may be either a fraction or a dimension.-->
32+
<item type="dimen" name="dialog_fixed_height_major">60%</item>
33+
<!-- The platform's desired fixed height for a dialog along the minor axis
34+
(the screen is in landscape). This may be either a fraction or a dimension.-->
35+
<item type="dimen" name="dialog_fixed_height_minor">90%</item>
36+
2337
</resources>
2438

2539

0 commit comments

Comments
 (0)