Skip to content

Commit 22af38c

Browse files
committed
API review fixes
- Remove the notion of channel from an application perspective - Remove the use of DnsSd as part of API and add a protocol type to allow future extensions - Use the listener object as a handler for stop and unregister operations. Also, we now allow multiple active discovery operations. - Remove init/deinit operations in favour of setting up construction Bug:6434844 Change-Id: Id15521d571aac9c4053d81184ad66dfc54f636de
1 parent faac929 commit 22af38c

File tree

6 files changed

+627
-691
lines changed

6 files changed

+627
-691
lines changed

api/current.txt

Lines changed: 38 additions & 50 deletions
Original file line numberDiff line numberDiff line change
@@ -12531,21 +12531,6 @@ package android.net.http {
1253112531

1253212532
package android.net.nsd {
1253312533

12534-
public class DnsSdServiceInfo implements android.os.Parcelable {
12535-
ctor public DnsSdServiceInfo();
12536-
method public int describeContents();
12537-
method public java.net.InetAddress getHost();
12538-
method public int getPort();
12539-
method public java.lang.String getServiceName();
12540-
method public java.lang.String getServiceType();
12541-
method public void setHost(java.net.InetAddress);
12542-
method public void setPort(int);
12543-
method public void setServiceName(java.lang.String);
12544-
method public void setServiceType(java.lang.String);
12545-
method public void writeToParcel(android.os.Parcel, int);
12546-
field public static final android.os.Parcelable.Creator CREATOR;
12547-
}
12548-
1254912534
public class DnsSdTxtRecord implements android.os.Parcelable {
1255012535
ctor public DnsSdTxtRecord();
1255112536
ctor public DnsSdTxtRecord(byte[]);
@@ -12562,53 +12547,56 @@ package android.net.nsd {
1256212547
field public static final android.os.Parcelable.Creator CREATOR;
1256312548
}
1256412549

12565-
public class NsdManager {
12566-
method public void deinitialize(android.net.nsd.NsdManager.Channel);
12567-
method public void discoverServices(android.net.nsd.NsdManager.Channel, java.lang.String, android.net.nsd.NsdManager.DnsSdDiscoveryListener);
12568-
method public void initialize(android.content.Context, android.os.Looper, android.net.nsd.NsdManager.ChannelListener);
12569-
method public void registerService(android.net.nsd.NsdManager.Channel, java.lang.String, java.lang.String, int, android.net.nsd.NsdManager.DnsSdRegisterListener);
12570-
method public void resolveService(android.net.nsd.NsdManager.Channel, java.lang.String, java.lang.String, android.net.nsd.NsdManager.DnsSdResolveListener);
12571-
method public void stopServiceDiscovery(android.net.nsd.NsdManager.Channel, android.net.nsd.NsdManager.ActionListener);
12572-
method public void unregisterService(android.net.nsd.NsdManager.Channel, int, android.net.nsd.NsdManager.ActionListener);
12550+
public final class NsdManager {
12551+
method public void discoverServices(java.lang.String, int, android.net.nsd.NsdManager.DiscoveryListener);
12552+
method public void registerService(android.net.nsd.NsdServiceInfo, int, android.net.nsd.NsdManager.RegistrationListener);
12553+
method public void resolveService(android.net.nsd.NsdServiceInfo, android.net.nsd.NsdManager.ResolveListener);
12554+
method public void stopServiceDiscovery(android.net.nsd.NsdManager.DiscoveryListener);
12555+
method public void unregisterService(android.net.nsd.NsdManager.RegistrationListener);
1257312556
field public static final java.lang.String ACTION_NSD_STATE_CHANGED = "android.net.nsd.STATE_CHANGED";
12574-
field public static final int ALREADY_ACTIVE = 3; // 0x3
12575-
field public static final int BUSY = 2; // 0x2
12576-
field public static final int ERROR = 0; // 0x0
1257712557
field public static final java.lang.String EXTRA_NSD_STATE = "nsd_state";
12578-
field public static final int MAX_REGS_REACHED = 4; // 0x4
12558+
field public static final int FAILURE_ALREADY_ACTIVE = 3; // 0x3
12559+
field public static final int FAILURE_INTERNAL_ERROR = 0; // 0x0
12560+
field public static final int FAILURE_MAX_LIMIT = 4; // 0x4
1257912561
field public static final int NSD_STATE_DISABLED = 1; // 0x1
1258012562
field public static final int NSD_STATE_ENABLED = 2; // 0x2
12581-
field public static final int UNSUPPORTED = 1; // 0x1
12582-
}
12583-
12584-
public static abstract interface NsdManager.ActionListener {
12585-
method public abstract void onFailure(int);
12586-
method public abstract void onSuccess();
12563+
field public static final int PROTOCOL_DNS_SD = 1; // 0x1
1258712564
}
1258812565

12589-
public static class NsdManager.Channel {
12566+
public static abstract interface NsdManager.DiscoveryListener {
12567+
method public abstract void onDiscoveryStarted(java.lang.String);
12568+
method public abstract void onDiscoveryStopped(java.lang.String);
12569+
method public abstract void onServiceFound(android.net.nsd.NsdServiceInfo);
12570+
method public abstract void onServiceLost(android.net.nsd.NsdServiceInfo);
12571+
method public abstract void onStartDiscoveryFailed(java.lang.String, int);
12572+
method public abstract void onStopDiscoveryFailed(java.lang.String, int);
1259012573
}
1259112574

12592-
public static abstract interface NsdManager.ChannelListener {
12593-
method public abstract void onChannelConnected(android.net.nsd.NsdManager.Channel);
12594-
method public abstract void onChannelDisconnected();
12575+
public static abstract interface NsdManager.RegistrationListener {
12576+
method public abstract void onRegistrationFailed(android.net.nsd.NsdServiceInfo, int);
12577+
method public abstract void onServiceRegistered(android.net.nsd.NsdServiceInfo);
12578+
method public abstract void onServiceUnregistered(android.net.nsd.NsdServiceInfo);
12579+
method public abstract void onUnregistrationFailed(android.net.nsd.NsdServiceInfo, int);
1259512580
}
1259612581

12597-
public static abstract interface NsdManager.DnsSdDiscoveryListener {
12598-
method public abstract void onFailure(int);
12599-
method public abstract void onServiceFound(android.net.nsd.DnsSdServiceInfo);
12600-
method public abstract void onServiceLost(android.net.nsd.DnsSdServiceInfo);
12601-
method public abstract void onStarted(java.lang.String);
12582+
public static abstract interface NsdManager.ResolveListener {
12583+
method public abstract void onResolveFailed(android.net.nsd.NsdServiceInfo, int);
12584+
method public abstract void onServiceResolved(android.net.nsd.NsdServiceInfo);
1260212585
}
1260312586

12604-
public static abstract interface NsdManager.DnsSdRegisterListener {
12605-
method public abstract void onFailure(int);
12606-
method public abstract void onServiceRegistered(int, android.net.nsd.DnsSdServiceInfo);
12607-
}
12608-
12609-
public static abstract interface NsdManager.DnsSdResolveListener {
12610-
method public abstract void onFailure(int);
12611-
method public abstract void onServiceResolved(android.net.nsd.DnsSdServiceInfo);
12587+
public final class NsdServiceInfo implements android.os.Parcelable {
12588+
ctor public NsdServiceInfo();
12589+
method public int describeContents();
12590+
method public java.net.InetAddress getHost();
12591+
method public int getPort();
12592+
method public java.lang.String getServiceName();
12593+
method public java.lang.String getServiceType();
12594+
method public void setHost(java.net.InetAddress);
12595+
method public void setPort(int);
12596+
method public void setServiceName(java.lang.String);
12597+
method public void setServiceType(java.lang.String);
12598+
method public void writeToParcel(android.os.Parcel, int);
12599+
field public static final android.os.Parcelable.Creator CREATOR;
1261212600
}
1261312601

1261412602
}

core/java/android/app/ContextImpl.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -387,7 +387,7 @@ public Object createService(ContextImpl ctx) {
387387
public Object createService(ContextImpl ctx) {
388388
IBinder b = ServiceManager.getService(NSD_SERVICE);
389389
INsdManager service = INsdManager.Stub.asInterface(b);
390-
return new NsdManager(service);
390+
return new NsdManager(ctx.getOuterContext(), service);
391391
}});
392392

393393
// Note: this was previously cached in a static variable, but

core/java/android/net/nsd/NetworkServiceInfo.java

Lines changed: 0 additions & 32 deletions
This file was deleted.

0 commit comments

Comments
 (0)