Skip to content

Commit 23321b8

Browse files
enh-googleAndroid (Google) Code Review
authored andcommitted
Merge "Use ICU's CLDR data for "AM" and "PM" strings." into jb-mr1-dev
2 parents c12d642 + 4af8534 commit 23321b8

File tree

74 files changed

+9
-154
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

74 files changed

+9
-154
lines changed

core/java/android/text/format/DateUtils.java

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,8 @@
2929
import java.util.Locale;
3030
import java.util.TimeZone;
3131

32+
import libcore.icu.LocaleData;
33+
3234
/**
3335
* This class contains various date-related utilities for creating text for things like
3436
* elapsed time and date ranges, strings for days of the week and months, and AM/PM text etc.
@@ -128,10 +130,6 @@ public class DateUtils
128130
com.android.internal.R.string.month_shortest_november,
129131
com.android.internal.R.string.month_shortest_december,
130132
};
131-
private static final int[] sAmPm = new int[] {
132-
com.android.internal.R.string.am,
133-
com.android.internal.R.string.pm,
134-
};
135133
private static Configuration sLastConfig;
136134
private static java.text.DateFormat sStatusTimeFormat;
137135
private static String sElapsedFormatMMSS;
@@ -359,8 +357,7 @@ public static String getDayOfWeekString(int dayOfWeek, int abbrev) {
359357
*/
360358
@Deprecated
361359
public static String getAMPMString(int ampm) {
362-
Resources r = Resources.getSystem();
363-
return r.getString(sAmPm[ampm - Calendar.AM]);
360+
return LocaleData.get(Locale.getDefault()).amPm[ampm - Calendar.AM];
364361
}
365362

366363
/**

core/java/android/text/format/Time.java

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,8 @@
2121
import java.util.Locale;
2222
import java.util.TimeZone;
2323

24+
import libcore.icu.LocaleData;
25+
2426
/**
2527
* An alternative to the {@link java.util.Calendar} and
2628
* {@link java.util.GregorianCalendar} classes. An instance of the Time class represents
@@ -382,8 +384,10 @@ public String format(String format) {
382384
sTimeOnlyFormat = r.getString(com.android.internal.R.string.time_of_day);
383385
sDateOnlyFormat = r.getString(com.android.internal.R.string.month_day_year);
384386
sDateTimeFormat = r.getString(com.android.internal.R.string.date_and_time);
385-
sAm = r.getString(com.android.internal.R.string.am);
386-
sPm = r.getString(com.android.internal.R.string.pm);
387+
388+
LocaleData localeData = LocaleData.get(locale);
389+
sAm = localeData.amPm[0];
390+
sPm = localeData.amPm[1];
387391

388392
sLocale = locale;
389393
}

core/res/res/values-af/donottranslate-cldr.xml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -85,9 +85,6 @@
8585
<string name="day_of_week_shortest_friday">6</string>
8686
<string name="day_of_week_shortest_saturday">7</string>
8787

88-
<string name="am">vm.</string>
89-
<string name="pm">nm.</string>
90-
9188
<string name="hour_minute_24">%-k:%M</string>
9289
<string name="hour_minute_ampm">%-l:%M %p</string>
9390
<string name="hour_minute_cap_ampm">%-l:%M %^p</string>

core/res/res/values-am/donottranslate-cldr.xml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -85,9 +85,6 @@
8585
<string name="day_of_week_shortest_friday">ዓ</string>
8686
<string name="day_of_week_shortest_saturday">ቅ</string>
8787

88-
<string name="am">ጡዋት</string>
89-
<string name="pm">ከሳዓት</string>
90-
9188
<string name="hour_minute_24">%-k:%M</string>
9289
<string name="hour_minute_ampm">%-l:%M %p</string>
9390
<string name="hour_minute_cap_ampm">%-l:%M %p</string>

core/res/res/values-ar-rEG/donottranslate-cldr.xml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,8 +85,6 @@
8585
<string name="day_of_week_shortest_friday">ج</string>
8686
<string name="day_of_week_shortest_saturday">س</string>
8787

88-
<string name="am">ص</string>
89-
<string name="pm">م</string>
9088
<string name="yesterday">أمس</string>
9189
<string name="today">اليوم</string>
9290
<string name="tomorrow">غدًا</string>

core/res/res/values-ar/donottranslate-cldr.xml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,8 +85,6 @@
8585
<string name="day_of_week_shortest_friday">ج</string>
8686
<string name="day_of_week_shortest_saturday">س</string>
8787

88-
<string name="am">ص</string>
89-
<string name="pm">م</string>
9088
<string name="yesterday">أمس</string>
9189
<string name="today">اليوم</string>
9290
<string name="tomorrow">غدًا</string>

core/res/res/values-be/donottranslate-cldr.xml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,8 +74,6 @@
7474
<string name="day_of_week_shortest_friday">п</string>
7575
<string name="day_of_week_shortest_saturday">с</string>
7676

77-
<string name="am">да палудня</string>
78-
<string name="pm">пасля палудня</string>
7977
<string name="yesterday">учора</string>
8078
<string name="today">сёння</string>
8179
<string name="tomorrow">заўтра</string>

core/res/res/values-bg/donottranslate-cldr.xml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,8 +85,6 @@
8585
<string name="day_of_week_shortest_friday">п</string>
8686
<string name="day_of_week_shortest_saturday">с</string>
8787

88-
<string name="am">пр. об.</string>
89-
<string name="pm">сл. об.</string>
9088
<string name="yesterday">Вчера</string>
9189
<string name="today">Днес</string>
9290
<string name="tomorrow">Утре</string>

core/res/res/values-ca-rES/donottranslate-cldr.xml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,8 +85,6 @@
8585
<string name="day_of_week_shortest_friday">v</string>
8686
<string name="day_of_week_shortest_saturday">s</string>
8787

88-
<string name="am">a.m.</string>
89-
<string name="pm">p.m.</string>
9088
<string name="yesterday">ahir</string>
9189
<string name="today">avui</string>
9290
<string name="tomorrow">demà</string>

core/res/res/values-ca/donottranslate-cldr.xml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,8 +85,6 @@
8585
<string name="day_of_week_shortest_friday">v</string>
8686
<string name="day_of_week_shortest_saturday">s</string>
8787

88-
<string name="am">a.m.</string>
89-
<string name="pm">p.m.</string>
9088
<string name="yesterday">ahir</string>
9189
<string name="today">avui</string>
9290
<string name="tomorrow">demà</string>

0 commit comments

Comments
 (0)