Skip to content

Commit 24597eb

Browse files
Robert GreenwaltAndroid (Google) Code Review
authored andcommitted
Merge "Tone down Tethering logs." into ics-mr1
2 parents d400d03 + fd1be2b commit 24597eb

File tree

1 file changed

+11
-12
lines changed

1 file changed

+11
-12
lines changed

services/java/com/android/server/connectivity/Tethering.java

Lines changed: 11 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ public class Tethering extends INetworkManagementEventObserver.Stub {
7373
private Context mContext;
7474
private final static String TAG = "Tethering";
7575
private final static boolean DBG = true;
76-
private final static boolean VDBG = true;
76+
private final static boolean VDBG = false;
7777

7878
// TODO - remove both of these - should be part of interface inspection/selection stuff
7979
private String[] mTetherableUsbRegexs;
@@ -228,7 +228,7 @@ public void interfaceStatusChanged(String iface, boolean up) {
228228
if (isUsb(iface)) {
229229
// ignore usb0 down after enabling RNDIS
230230
// we will handle disconnect in interfaceRemoved instead
231-
if (VDBG) Log.d(TAG, "ignoring interface down for " + iface);
231+
if (VDBG) Log.d(TAG, "ignore interface down for " + iface);
232232
} else if (sm != null) {
233233
sm.sendMessage(TetherInterfaceSM.CMD_INTERFACE_DOWN);
234234
mIfaces.remove(iface);
@@ -298,7 +298,6 @@ public void interfaceAdded(String iface) {
298298
mIfaces.put(iface, sm);
299299
sm.start();
300300
}
301-
if (VDBG) Log.d(TAG, "interfaceAdded :" + iface);
302301
}
303302

304303
public void interfaceRemoved(String iface) {
@@ -415,7 +414,7 @@ private void sendTetherStateChangedBroadcast() {
415414
broadcast.putStringArrayListExtra(ConnectivityManager.EXTRA_ERRORED_TETHER,
416415
erroredList);
417416
mContext.sendStickyBroadcast(broadcast);
418-
if (VDBG) {
417+
if (DBG) {
419418
Log.d(TAG, "sendTetherStateChangedBroadcast " + availableList.size() + ", " +
420419
activeList.size() + ", " + erroredList.size());
421420
}
@@ -865,7 +864,7 @@ public void enter() {
865864

866865
@Override
867866
public boolean processMessage(Message message) {
868-
if (VDBG) Log.d(TAG, "InitialState.processMessage what=" + message.what);
867+
if (DBG) Log.d(TAG, "InitialState.processMessage what=" + message.what);
869868
boolean retValue = true;
870869
switch (message.what) {
871870
case CMD_TETHER_REQUESTED:
@@ -906,7 +905,7 @@ public void enter() {
906905
}
907906
@Override
908907
public boolean processMessage(Message message) {
909-
if (VDBG) Log.d(TAG, "StartingState.processMessage what=" + message.what);
908+
if (DBG) Log.d(TAG, "StartingState.processMessage what=" + message.what);
910909
boolean retValue = true;
911910
switch (message.what) {
912911
// maybe a parent class?
@@ -985,7 +984,7 @@ private void cleanupUpstream() {
985984

986985
@Override
987986
public boolean processMessage(Message message) {
988-
if (VDBG) Log.d(TAG, "TetheredState.processMessage what=" + message.what);
987+
if (DBG) Log.d(TAG, "TetheredState.processMessage what=" + message.what);
989988
boolean retValue = true;
990989
boolean error = false;
991990
switch (message.what) {
@@ -1061,7 +1060,7 @@ public boolean processMessage(Message message) {
10611060
ConnectivityManager.TETHER_ERROR_MASTER_ERROR);
10621061
break;
10631062
}
1064-
if (VDBG) Log.d(TAG, "Tether lost upstream connection " + mIfaceName);
1063+
if (DBG) Log.d(TAG, "Tether lost upstream connection " + mIfaceName);
10651064
sendTetherStateChangedBroadcast();
10661065
if (mUsb) {
10671066
if (!Tethering.this.configureUsbIface(false)) {
@@ -1296,7 +1295,7 @@ protected void chooseUpstreamType(boolean tryCell) {
12961295
}
12971296
}
12981297

1299-
if (VDBG) {
1298+
if (DBG) {
13001299
Log.d(TAG, "chooseUpstreamType(" + tryCell + "), preferredApn ="
13011300
+ mPreferredUpstreamMobileApn + ", got type=" + upType);
13021301
}
@@ -1328,7 +1327,7 @@ protected void chooseUpstreamType(boolean tryCell) {
13281327
}
13291328

13301329
protected void notifyTetheredOfNewUpstreamIface(String ifaceName) {
1331-
if (VDBG) Log.d(TAG, "notifying tethered with iface =" + ifaceName);
1330+
if (DBG) Log.d(TAG, "notifying tethered with iface =" + ifaceName);
13321331
mUpstreamIfaceName = ifaceName;
13331332
for (Object o : mNotifyList) {
13341333
TetherInterfaceSM sm = (TetherInterfaceSM)o;
@@ -1344,7 +1343,7 @@ public void enter() {
13441343
}
13451344
@Override
13461345
public boolean processMessage(Message message) {
1347-
if (VDBG) Log.d(TAG, "MasterInitialState.processMessage what=" + message.what);
1346+
if (DBG) Log.d(TAG, "MasterInitialState.processMessage what=" + message.what);
13481347
boolean retValue = true;
13491348
switch (message.what) {
13501349
case CMD_TETHER_MODE_REQUESTED:
@@ -1386,7 +1385,7 @@ public void exit() {
13861385
}
13871386
@Override
13881387
public boolean processMessage(Message message) {
1389-
if (VDBG) Log.d(TAG, "TetherModeAliveState.processMessage what=" + message.what);
1388+
if (DBG) Log.d(TAG, "TetherModeAliveState.processMessage what=" + message.what);
13901389
boolean retValue = true;
13911390
switch (message.what) {
13921391
case CMD_TETHER_MODE_REQUESTED:

0 commit comments

Comments
 (0)