Skip to content

Commit 2d25d46

Browse files
Amith YamasaniAndroid (Google) Code Review
authored andcommitted
Merge "Fixes PreferenceScreen padding and scrollbar position." into jb-dev
2 parents 91901ae + f9638a4 commit 2d25d46

File tree

3 files changed

+10
-4
lines changed

3 files changed

+10
-4
lines changed

core/java/android/preference/PreferenceScreen.java

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424
import android.os.Parcelable;
2525
import android.text.TextUtils;
2626
import android.util.AttributeSet;
27+
import android.view.LayoutInflater;
2728
import android.view.View;
2829
import android.view.Window;
2930
import android.widget.AbsListView;
@@ -153,7 +154,12 @@ private void showDialog(Bundle state) {
153154
if (mListView != null) {
154155
mListView.setAdapter(null);
155156
}
156-
mListView = new ListView(context);
157+
158+
LayoutInflater inflater = (LayoutInflater)
159+
context.getSystemService(Context.LAYOUT_INFLATER_SERVICE);
160+
View childPrefScreen = inflater.inflate(
161+
com.android.internal.R.layout.preference_list_fragment, null);
162+
mListView = (ListView) childPrefScreen.findViewById(android.R.id.list);
157163
bind(mListView);
158164

159165
// Set the title bar if title is available, else no title bar
@@ -164,7 +170,7 @@ private void showDialog(Bundle state) {
164170
} else {
165171
dialog.setTitle(title);
166172
}
167-
dialog.setContentView(mListView);
173+
dialog.setContentView(childPrefScreen);
168174
dialog.setOnDismissListener(this);
169175
if (state != null) {
170176
dialog.onRestoreInstanceState(state);

core/res/res/values-h720dp/dimens.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,6 @@
2525
<dimen name="preference_screen_header_padding_side">0dip</dimen>
2626

2727
<integer name="preference_screen_header_scrollbarStyle">0x0</integer> <!-- insideOverlay -->
28-
<integer name="preference_fragment_scrollbarStyle">0x0</integer> <!-- insideOverlay -->
28+
<integer name="preference_fragment_scrollbarStyle">0x02000000</integer> <!-- outsideOverlay -->
2929

3030
</resources>

core/res/res/values-w720dp/dimens.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,5 +33,5 @@
3333
<dimen name="preference_screen_header_padding_side">0dip</dimen>
3434

3535
<integer name="preference_screen_header_scrollbarStyle">0x0</integer> <!-- insideOverlay -->
36-
<integer name="preference_fragment_scrollbarStyle">0x0</integer> <!-- insideOverlay -->
36+
<integer name="preference_fragment_scrollbarStyle">0x02000000</integer> <!-- outsideOverlay -->
3737
</resources>

0 commit comments

Comments
 (0)