Skip to content

Commit 32319dd

Browse files
author
Jake Hamby
committed
Add "format" extra to SMS delivery report intents.
The MMS app was updated for multiple SMS dispatcher support, passing the "format" extra into SmsMessage.createFromPdu() so that the PDU is interpreted as the correct format (3GPP or 3GPP2). This change adds the "format" extra to the intents that are sent for SMS delivery reports. The MMS app is already expecting this extra, so this change fixes a NPE that was introduced with the last change. Bug: 5434052 Change-Id: I38b97f166c78d246d721ca1db8a4a18a2c6529bd
1 parent 94e8471 commit 32319dd

File tree

2 files changed

+2
-0
lines changed

2 files changed

+2
-0
lines changed

telephony/java/com/android/internal/telephony/cdma/CdmaSMSDispatcher.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -88,6 +88,7 @@ private void handleCdmaStatusReport(SmsMessage sms) {
8888
PendingIntent intent = tracker.mDeliveryIntent;
8989
Intent fillIn = new Intent();
9090
fillIn.putExtra("pdu", sms.getPdu());
91+
fillIn.putExtra("format", android.telephony.SmsMessage.FORMAT_3GPP2);
9192
try {
9293
intent.send(mContext, Activity.RESULT_OK, fillIn);
9394
} catch (CanceledException ex) {}

telephony/java/com/android/internal/telephony/gsm/GsmSMSDispatcher.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -122,6 +122,7 @@ private void handleStatusReport(AsyncResult ar) {
122122
PendingIntent intent = tracker.mDeliveryIntent;
123123
Intent fillIn = new Intent();
124124
fillIn.putExtra("pdu", IccUtils.hexStringToBytes(pduString));
125+
fillIn.putExtra("format", android.telephony.SmsMessage.FORMAT_3GPP);
125126
try {
126127
intent.send(mContext, Activity.RESULT_OK, fillIn);
127128
} catch (CanceledException ex) {}

0 commit comments

Comments
 (0)