Skip to content

Commit 3bc9a79

Browse files
author
Robert Greenwalt
committed
Add bit to eventlog to handle new network types
bug:5514930 Change-Id: I29288cb39902578992ee53b171f228f8eeb407fd
1 parent 7725180 commit 3bc9a79

File tree

2 files changed

+11
-11
lines changed

2 files changed

+11
-11
lines changed

services/java/com/android/server/ConnectivityService.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2422,15 +2422,15 @@ public void handleMessage(Message msg) {
24222422
}
24232423

24242424
// Connectivity state changed:
2425-
// [31-13] Reserved for future use
2426-
// [12-9] Network subtype (for mobile network, as defined
2425+
// [31-14] Reserved for future use
2426+
// [13-10] Network subtype (for mobile network, as defined
24272427
// by TelephonyManager)
2428-
// [8-3] Detailed state ordinal (as defined by
2428+
// [9-4] Detailed state ordinal (as defined by
24292429
// NetworkInfo.DetailedState)
2430-
// [2-0] Network type (as defined by ConnectivityManager)
2431-
int eventLogParam = (info.getType() & 0x7) |
2432-
((info.getDetailedState().ordinal() & 0x3f) << 3) |
2433-
(info.getSubtype() << 9);
2430+
// [3-0] Network type (as defined by ConnectivityManager)
2431+
int eventLogParam = (info.getType() & 0xf) |
2432+
((info.getDetailedState().ordinal() & 0x3f) << 4) |
2433+
(info.getSubtype() << 10);
24342434
EventLog.writeEvent(EventLogTags.CONNECTIVITY_STATE_CHANGED,
24352435
eventLogParam);
24362436

services/java/com/android/server/EventLogTags.logtags

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -134,10 +134,10 @@ option java_package com.android.server
134134
# ConnectivityService.java
135135
# ---------------------------
136136
# Connectivity state changed:
137-
# [31-13] Reserved for future use
138-
# [12- 9] Network subtype (for mobile network, as defined by TelephonyManager)
139-
# [ 8- 3] Detailed state ordinal (as defined by NetworkInfo.DetailedState)
140-
# [ 2- 0] Network type (as defined by ConnectivityManager)
137+
# [31-14] Reserved for future use
138+
# [13-10] Network subtype (for mobile network, as defined by TelephonyManager)
139+
# [ 9- 4] Detailed state ordinal (as defined by NetworkInfo.DetailedState)
140+
# [ 3- 0] Network type (as defined by ConnectivityManager)
141141
50020 connectivity_state_changed (custom|1|5)
142142

143143

0 commit comments

Comments
 (0)