Fix issue #7272775: Auto Start Apps Not Starting

Bad defaults were causing stopped state to be set at each
boot.

Change-Id: I49b04e9c62f6ac391054201b508fddb6c7985615

Author: Dianne Hackborn

core/java/android/content/pm/PackageUserState.java

@@ -34,14 +34,6 @@ public class PackageUserState {
     public HashSet<String> enabledComponents;
 
     public PackageUserState() {
-        this(true);
-    }
-
-    /** @hide */
-    public PackageUserState(boolean isSystem) {
-        if (!isSystem) {
-            stopped = notLaunched = true;
-        }
         installed = true;
         enabled = COMPONENT_ENABLED_STATE_DEFAULT;
     }

services/java/com/android/server/pm/PackageSettingBase.java

@@ -65,8 +65,7 @@ class PackageSettingBase extends GrantedPermissions {
     boolean permissionsFixed;
     boolean haveGids;
 
-    private static final PackageUserState DEFAULT_USER_STATE = new PackageUserState(false);
-    private static final PackageUserState DEFAULT_SYSTEM_USER_STATE = new PackageUserState(true);
+    private static final PackageUserState DEFAULT_USER_STATE = new PackageUserState();
 
     // Whether this package is currently stopped, thus can not be
     // started until explicitly launched by the user.
@@ -176,7 +175,7 @@ public void copyFrom(PackageSettingBase base) {
     private PackageUserState modifyUserState(int userId) {
         PackageUserState state = userState.get(userId);
         if (state == null) {
-            state = new PackageUserState((pkgFlags&ApplicationInfo.FLAG_SYSTEM) != 0);
+            state = new PackageUserState();
             userState.put(userId, state);
         }
         return state;
@@ -187,8 +186,7 @@ public PackageUserState readUserState(int userId) {
         if (state != null) {
             return state;
         }
-        return ((pkgFlags&ApplicationInfo.FLAG_SYSTEM) != 0)
-                ? DEFAULT_SYSTEM_USER_STATE : DEFAULT_USER_STATE;
+        return DEFAULT_USER_STATE;
     }
 
     void setEnabled(int state, int userId) {