Skip to content

Commit 50c3102

Browse files
James DongAndroid (Google) Code Review
authored andcommitted
Merge "Support AMR as a file type so that it can be imported into movie studio"
2 parents 737f330 + f58ba65 commit 50c3102

File tree

3 files changed

+8
-3
lines changed

3 files changed

+8
-3
lines changed

media/java/android/media/videoeditor/AudioTrack.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -147,14 +147,16 @@ public AudioTrack(VideoEditor editor, String audioTrackId, String filename) thro
147147
} catch (Exception e) {
148148
throw new IllegalArgumentException(e.getMessage() + " : " + filename);
149149
}
150-
switch (mMANativeHelper.getFileType(properties.fileType)) {
150+
int fileType = mMANativeHelper.getFileType(properties.fileType);
151+
switch (fileType) {
151152
case MediaProperties.FILE_3GP:
152153
case MediaProperties.FILE_MP4:
153154
case MediaProperties.FILE_MP3:
155+
case MediaProperties.FILE_AMR:
154156
break;
155157

156158
default: {
157-
throw new IllegalArgumentException("Unsupported input file type");
159+
throw new IllegalArgumentException("Unsupported input file type: " + fileType);
158160
}
159161
}
160162
switch (mMANativeHelper.getAudioCodecType(properties.audioFormat)) {

media/java/android/media/videoeditor/MediaArtistNativeHelper.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3239,6 +3239,9 @@ int getFileType(int fileType) {
32393239
case FileType.M4V:
32403240
retValue = MediaProperties.FILE_M4V;
32413241
break;
3242+
case FileType.AMR:
3243+
retValue = MediaProperties.FILE_AMR;
3244+
break;
32423245

32433246
default:
32443247
retValue = -1;

media/java/android/media/videoeditor/MediaProperties.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -286,7 +286,7 @@ public final class MPEG4Level {
286286
*/
287287
public static final int FILE_3GP = 0;
288288
public static final int FILE_MP4 = 1;
289-
// 2 is for AMRNB
289+
public static final int FILE_AMR = 2;
290290
public static final int FILE_MP3 = 3;
291291
// 4 is for PCM
292292
public static final int FILE_JPEG = 5;

0 commit comments

Comments
 (0)