Skip to content

Commit 557a177

Browse files
Adam CohenAndroid (Google) Code Review
authored andcommitted
Merge "Working around issue where setting min height on RelativeLayout causes items to collapse. (Bug 5640357)" into ics-mr1
2 parents a124018 + 7cef80f commit 557a177

File tree

1 file changed

+28
-30
lines changed

1 file changed

+28
-30
lines changed

core/res/res/layout/global_actions_item.xml

Lines changed: 28 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -14,48 +14,46 @@
1414
limitations under the License.
1515
-->
1616

17-
<RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android"
17+
<!-- RelativeLayouts have an issue enforcing minimum heights, so just
18+
work around this for now with LinearLayouts. -->
19+
<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
1820
android:layout_width="match_parent"
19-
android:layout_height="?android:attr/listPreferredItemHeight"
21+
android:layout_height="wrap_content"
22+
android:minHeight="?android:attr/listPreferredItemHeight"
23+
android:orientation="horizontal"
2024

2125
android:paddingLeft="11dip"
2226
android:paddingTop="6dip"
2327
android:paddingBottom="6dip"
2428
>
25-
2629
<ImageView android:id="@+id/icon"
2730
android:layout_width="wrap_content"
2831
android:layout_height="match_parent"
29-
android:layout_alignParentTop="true"
30-
android:layout_alignParentBottom="true"
32+
android:layout_gravity="center"
3133
android:layout_marginRight="9dip"
32-
/>
33-
34-
35-
<TextView android:id="@+id/status"
36-
android:layout_width="match_parent"
37-
android:layout_height="26dip"
38-
39-
android:layout_toRightOf="@id/icon"
40-
android:layout_alignParentBottom="true"
41-
android:layout_alignParentRight="true"
42-
43-
android:textAppearance="?android:attr/textAppearanceSmall"
4434
/>
4535

46-
47-
<TextView android:id="@+id/message"
36+
<LinearLayout
37+
android:orientation="vertical"
4838
android:layout_width="match_parent"
4939
android:layout_height="wrap_content"
40+
android:layout_gravity="center_vertical"
41+
>
42+
<TextView android:id="@+id/message"
43+
android:layout_width="match_parent"
44+
android:layout_height="wrap_content"
45+
android:layout_gravity="top"
46+
47+
android:gravity="center_vertical"
48+
android:textAppearance="?android:attr/textAppearanceLarge"
49+
/>
50+
<TextView android:id="@+id/status"
51+
android:layout_width="match_parent"
52+
android:layout_height="wrap_content"
53+
android:layout_gravity="bottom"
54+
android:minHeight="26dp"
5055

51-
android:layout_toRightOf="@id/icon"
52-
android:layout_alignParentRight="true"
53-
android:layout_alignParentTop="true"
54-
android:layout_above="@id/status"
55-
android:layout_alignWithParentIfMissing="true"
56-
android:gravity="center_vertical"
57-
android:textAppearance="?android:attr/textAppearanceLarge"
58-
/>
59-
60-
61-
</RelativeLayout>
56+
android:textAppearance="?android:attr/textAppearanceSmall"
57+
/>
58+
</LinearLayout>
59+
</LinearLayout>

0 commit comments

Comments
 (0)