Skip to content

Commit 5c43ec9

Browse files
committed
Fix bug in TaskStackBuilder#addParentStack
Don't assume the initial component has a valid parent specified. Bug 6464209 Change-Id: I22aa4c0e667ea85dc46ad7320f4a9f52117af520
1 parent 1705b2a commit 5c43ec9

File tree

1 file changed

+3
-9
lines changed

1 file changed

+3
-9
lines changed

core/java/android/app/TaskStackBuilder.java

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -196,18 +196,12 @@ public TaskStackBuilder addParentStack(ComponentName sourceActivityName) {
196196
try {
197197
ActivityInfo info = pm.getActivityInfo(sourceActivityName, 0);
198198
String parentActivity = info.parentActivityName;
199-
Intent parent = new Intent().setComponent(
200-
new ComponentName(info.packageName, parentActivity));
201-
while (parent != null) {
199+
while (parentActivity != null) {
200+
Intent parent = new Intent().setComponent(
201+
new ComponentName(info.packageName, parentActivity));
202202
mIntents.add(insertAt, parent);
203203
info = pm.getActivityInfo(parent.getComponent(), 0);
204204
parentActivity = info.parentActivityName;
205-
if (parentActivity != null) {
206-
parent = new Intent().setComponent(
207-
new ComponentName(info.packageName, parentActivity));
208-
} else {
209-
parent = null;
210-
}
211205
}
212206
} catch (NameNotFoundException e) {
213207
Log.e(TAG, "Bad ComponentName while traversing activity parent metadata");

0 commit comments

Comments
 (0)