Skip to content

Commit 6fde309

Browse files
Matthew XieAndroid (Google) Code Review
authored andcommitted
Minor changes. Change some instance variables to be final.
Variable name changes, better code reability. Change-Id: I9f0e9c8a57d4bacf0723be1f91d621c592860683
1 parent a8c6df0 commit 6fde309

File tree

1 file changed

+9
-10
lines changed

1 file changed

+9
-10
lines changed

services/java/com/android/server/BluetoothManagerService.java

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -59,9 +59,9 @@ class BluetoothManagerService extends IBluetoothManager.Stub {
5959
private final Context mContext;
6060
private String mAddress;
6161
private String mName;
62-
private ContentResolver mContentResolver;
63-
private RemoteCallbackList<IBluetoothManagerCallback> mCallbacks;
64-
private RemoteCallbackList<IBluetoothStateChangeCallback> mStateChangeCallbacks;
62+
private final ContentResolver mContentResolver;
63+
private final RemoteCallbackList<IBluetoothManagerCallback> mCallbacks;
64+
private final RemoteCallbackList<IBluetoothStateChangeCallback> mStateChangeCallbacks;
6565
private IBluetooth mBluetooth;
6666
private boolean mBinding;
6767
private boolean mUnbinding;
@@ -121,10 +121,10 @@ public void onReceive(Context context, Intent intent) {
121121
mContentResolver = context.getContentResolver();
122122
mCallbacks = new RemoteCallbackList<IBluetoothManagerCallback>();
123123
mStateChangeCallbacks = new RemoteCallbackList<IBluetoothStateChangeCallback>();
124-
IntentFilter mFilter = new IntentFilter(BluetoothAdapter.ACTION_STATE_CHANGED);
125-
mFilter.addAction(BluetoothAdapter.ACTION_LOCAL_NAME_CHANGED);
126-
registerForAirplaneMode(mFilter);
127-
mContext.registerReceiver(mReceiver, mFilter);
124+
IntentFilter filter = new IntentFilter(BluetoothAdapter.ACTION_STATE_CHANGED);
125+
filter.addAction(BluetoothAdapter.ACTION_LOCAL_NAME_CHANGED);
126+
registerForAirplaneMode(filter);
127+
mContext.registerReceiver(mReceiver, filter);
128128
boolean airplaneModeOn = isAirplaneModeOn();
129129
boolean bluetoothOn = isBluetoothPersistedStateOn();
130130
loadStoredNameAndAddress();
@@ -512,8 +512,7 @@ public void handleMessage(Message msg) {
512512
Log.d(TAG, "MESSAGE_ENABLE: mBluetooth = " + mBluetooth +
513513
" isConnected = " + isConnected());
514514
}
515-
516-
boolean persist = (1==msg.arg1);
515+
boolean persist = (msg.arg1 == 1);
517516
if (persist) {
518517
persistBluetoothSetting(true);
519518
}
@@ -553,7 +552,7 @@ public void handleMessage(Message msg) {
553552
// [fc]: let AdapterServiceHandle
554553
}
555554
break;
556-
case MESSAGE_AIRPLANE_MODE_ON:;
555+
case MESSAGE_AIRPLANE_MODE_ON:
557556
if (DBG) {
558557
Log.d(TAG, "MESSAGE_AIRPLANE_MODE_ON: mBluetooth = " + mBluetooth +
559558
" isConnected = " + isConnected());

0 commit comments

Comments
 (0)