Skip to content

Commit 7b1e0c7

Browse files
committed
Removing default accessibility gesture handling.
1. The initial design was to have some accessibility gestures being handled by the system if the gesture handling access service does not consume the gesture. However, we are not sure what a good default is and once we add a default handler we cannot remove it since people may rely on it. Thus, we take the simples approach and let the accessibility service handle the gestures. If no gestures are handled the system will work in explore by touch as before. bug:5932640 Change-Id: I865a83549fa03b0141d27ce9713e9b7bb45a57b4
1 parent 8d8176d commit 7b1e0c7

File tree

6 files changed

+14
-297
lines changed

6 files changed

+14
-297
lines changed

Android.mk

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,6 @@ LOCAL_SRC_FILES := $(filter-out \
6161
LOCAL_SRC_FILES += \
6262
core/java/android/accessibilityservice/IAccessibilityServiceConnection.aidl \
6363
core/java/android/accessibilityservice/IAccessibilityServiceClient.aidl \
64-
core/java/android/accessibilityservice/IAccessibilityServiceClientCallback.aidl \
6564
core/java/android/accounts/IAccountManager.aidl \
6665
core/java/android/accounts/IAccountManagerResponse.aidl \
6766
core/java/android/accounts/IAccountAuthenticator.aidl \

CleanSpec.mk

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -129,6 +129,9 @@ $(call add-clean-step, rm -rf $(OUT_DIR)/host/$(HOST_PREBUILT_TAG)/obj/STATIC_LI
129129
$(call add-clean-step, rm -rf $(OUT_DIR)/target/common/obj/JAVA_LIBRARIES/framework_intermediates/src/core/java/android/accessibilityservice/IEventListener.java)
130130
$(call add-clean-step, rm -rf $(OUT_DIR)/target/common/obj/JAVA_LIBRARIES/framework_intermediates/src/core/java/android/accessibilityservice/IEventListener.P)
131131
$(call add-clean-step, rm -rf $(OUT_DIR)/target/common/obj/JAVA_LIBRARIES/framework_intermediates/src/core/java/android/view/accessibility/IAccessibilityManager.P)
132+
$(call add-clean-step, rm -rf $(OUT_DIR)/target/common/obj/JAVA_LIBRARIES/framework_intermediates/src/core/java/android/accessibilityservice/IAccessibilityServiceClientCallback.java)
133+
$(call add-clean-step, rm -rf $(OUT_DIR)/target/common/obj/JAVA_LIBRARIES/framework_intermediates/src/core/java/android/accessibilityservice/IAccessibilityServiceClientCallback.P)
134+
$(call add-clean-step, rm -rf $(OUT_DIR)/target/common/obj/JAVA_LIBRARIES/framework_intermediates/src/core/java/android/accessibilityservice/IAccessibilityServiceClient.P)
132135
# ************************************************
133136
# NEWER CLEAN STEPS MUST BE AT THE END OF THE LIST
134137
# ************************************************

core/java/android/accessibilityservice/AccessibilityService.java

Lines changed: 4 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -371,7 +371,7 @@ protected void onServiceConnected() {
371371
*
372372
* <strong>Note:</strong> To receive gestures an accessibility service must
373373
* request that the device is in touch exploration mode by setting the
374-
* {@link android.accessibilityservice.AccessibilityServiceInfo#FLAG_INCLUDE_NOT_IMPORTANT_VIEWS}
374+
* {@link android.accessibilityservice.AccessibilityServiceInfo#FLAG_REQUEST_TOUCH_EXPLORATION_MODE}
375375
* flag.
376376
*
377377
* @param gestureId The unique id of the performed gesture.
@@ -565,10 +565,8 @@ public void onAccessibilityEvent(AccessibilityEvent event) {
565565
mCaller.sendMessage(message);
566566
}
567567

568-
public void onGesture(int gestureId, IAccessibilityServiceClientCallback callback,
569-
int interactionId) {
570-
Message message = mCaller.obtainMessageIIO(DO_ON_GESTURE, gestureId, interactionId,
571-
callback);
568+
public void onGesture(int gestureId) {
569+
Message message = mCaller.obtainMessageI(DO_ON_GESTURE, gestureId);
572570
mCaller.sendMessage(message);
573571
}
574572

@@ -601,15 +599,7 @@ public void executeMessage(Message message) {
601599
return;
602600
case DO_ON_GESTURE :
603601
final int gestureId = message.arg1;
604-
final int interactionId = message.arg2;
605-
IAccessibilityServiceClientCallback callback =
606-
(IAccessibilityServiceClientCallback) message.obj;
607-
final boolean handled = mCallback.onGesture(gestureId);
608-
try {
609-
callback.setGestureResult(gestureId, handled, interactionId);
610-
} catch (RemoteException re) {
611-
Log.e(LOG_TAG, "Error calling back with the gesture resut.", re);
612-
}
602+
mCallback.onGesture(gestureId);
613603
return;
614604
default :
615605
Log.w(LOG_TAG, "Unknown message type " + message.what);

core/java/android/accessibilityservice/IAccessibilityServiceClient.aidl

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616

1717
package android.accessibilityservice;
1818

19-
import android.accessibilityservice.IAccessibilityServiceClientCallback;
2019
import android.accessibilityservice.IAccessibilityServiceConnection;
2120
import android.view.accessibility.AccessibilityEvent;
2221

@@ -33,5 +32,5 @@ import android.view.accessibility.AccessibilityEvent;
3332

3433
void onInterrupt();
3534

36-
void onGesture(int gesture, in IAccessibilityServiceClientCallback callback, int interactionId);
35+
void onGesture(int gesture);
3736
}

core/java/android/accessibilityservice/IAccessibilityServiceClientCallback.aidl

Lines changed: 0 additions & 30 deletions
This file was deleted.

0 commit comments

Comments
 (0)