Skip to content

Commit 83a708e

Browse files
isheriffAndroid (Google) Code Review
authored andcommitted
Merge "Handle null SSID cleanly" into jb-dev
2 parents 47f88d6 + 00a10a1 commit 83a708e

File tree

2 files changed

+9
-6
lines changed

2 files changed

+9
-6
lines changed

services/java/com/android/server/net/NetworkPolicyManagerService.java

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -500,12 +500,14 @@ public void onReceive(Context context, Intent intent) {
500500
if (reason == CHANGE_REASON_REMOVED) {
501501
final WifiConfiguration config = intent.getParcelableExtra(
502502
EXTRA_WIFI_CONFIGURATION);
503-
final NetworkTemplate template = NetworkTemplate.buildTemplateWifi(
504-
removeDoubleQuotes(config.SSID));
505-
synchronized (mRulesLock) {
506-
if (mNetworkPolicy.containsKey(template)) {
507-
mNetworkPolicy.remove(template);
508-
writePolicyLocked();
503+
if (config.SSID != null) {
504+
final NetworkTemplate template = NetworkTemplate.buildTemplateWifi(
505+
removeDoubleQuotes(config.SSID));
506+
synchronized (mRulesLock) {
507+
if (mNetworkPolicy.containsKey(template)) {
508+
mNetworkPolicy.remove(template);
509+
writePolicyLocked();
510+
}
509511
}
510512
}
511513
}

wifi/java/android/net/wifi/WifiInfo.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -266,6 +266,7 @@ static SupplicantState valueOf(String stateName) {
266266

267267
/** {@hide} */
268268
public static String removeDoubleQuotes(String string) {
269+
if (string == null) return null;
269270
final int length = string.length();
270271
if ((length > 1) && (string.charAt(0) == '"') && (string.charAt(length - 1) == '"')) {
271272
return string.substring(1, length - 1);

0 commit comments

Comments
 (0)