Skip to content

Commit 88759bb

Browse files
committed
Update WifiManager API
Use feedback based on NSD to update WifiManager API Change-Id: I0c1dc74f7e2fa7cd697a995b7194e3e0366d7981
1 parent b10f455 commit 88759bb

File tree

5 files changed

+166
-198
lines changed

5 files changed

+166
-198
lines changed

core/java/android/app/ContextImpl.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -477,7 +477,7 @@ public Object createService(ContextImpl ctx) {
477477
public Object createService(ContextImpl ctx) {
478478
IBinder b = ServiceManager.getService(WIFI_SERVICE);
479479
IWifiManager service = IWifiManager.Stub.asInterface(b);
480-
return new WifiManager(service, ctx.mMainThread.getHandler());
480+
return new WifiManager(ctx.getOuterContext(), service);
481481
}});
482482

483483
registerService(WIFI_P2P_SERVICE, new ServiceFetcher() {

core/tests/ConnectivityManagerTest/src/com/android/connectivitymanagertest/ConnectivityManagerTestActivity.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,6 @@ public class ConnectivityManagerTestActivity extends Activity {
9494
* Control Wifi States
9595
*/
9696
public WifiManager mWifiManager;
97-
public WifiManager.Channel mChannel;
9897

9998
/*
10099
* Verify connectivity state
@@ -242,7 +241,6 @@ protected void onCreate(Bundle savedInstanceState) {
242241
// Get an instance of WifiManager
243242
mWifiManager =(WifiManager)getSystemService(Context.WIFI_SERVICE);
244243
mContext = this;
245-
mChannel = mWifiManager.initialize(mContext, mContext.getMainLooper(), null);
246244

247245
if (mWifiManager.isWifiApEnabled()) {
248246
// if soft AP is enabled, disable it
@@ -599,7 +597,7 @@ public boolean connectToWifiWithConfiguration(WifiConfiguration config) {
599597
log("found " + ssid + " in the scan result list");
600598
log("retry: " + retry);
601599
foundApInScanResults = true;
602-
mWifiManager.connect(mChannel, config,
600+
mWifiManager.connect(config,
603601
new WifiManager.ActionListener() {
604602
public void onSuccess() {
605603
}
@@ -658,7 +656,7 @@ public boolean disconnectAP() {
658656
for (WifiConfiguration wifiConfig: wifiConfigList) {
659657
log("remove wifi configuration: " + wifiConfig.networkId);
660658
int netId = wifiConfig.networkId;
661-
mWifiManager.forget(mChannel, netId, new WifiManager.ActionListener() {
659+
mWifiManager.forget(netId, new WifiManager.ActionListener() {
662660
public void onSuccess() {
663661
}
664662
public void onFailure(int reason) {

core/tests/ConnectivityManagerTest/src/com/android/connectivitymanagertest/functional/WifiConnectionTest.java

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,6 @@ public class WifiConnectionTest
6363
private ConnectivityManagerTestActivity mAct;
6464
private ConnectivityManagerTestRunner mRunner;
6565
private WifiManager mWifiManager = null;
66-
private WifiManager.Channel mChannel;
6766
private Set<WifiConfiguration> enabledNetworks = null;
6867

6968
public WifiConnectionTest() {
@@ -77,7 +76,6 @@ public void setUp() throws Exception {
7776
mWifiManager = (WifiManager) mRunner.getContext().getSystemService(Context.WIFI_SERVICE);
7877

7978
mAct = getActivity();
80-
mChannel = mWifiManager.initialize(mAct, mAct.getMainLooper(), null);
8179

8280
networks = mAct.loadNetworkConfigurations();
8381
if (DEBUG) {
@@ -93,24 +91,6 @@ public void setUp() throws Exception {
9391
assertTrue("wpa_supplicant is not started ", mAct.mWifiManager.pingSupplicant());
9492
}
9593

96-
private class WifiServiceHandler extends Handler {
97-
@Override
98-
public void handleMessage(Message msg) {
99-
switch (msg.what) {
100-
case AsyncChannel.CMD_CHANNEL_HALF_CONNECTED:
101-
if (msg.arg1 == AsyncChannel.STATUS_SUCCESSFUL) {
102-
//AsyncChannel in msg.obj
103-
} else {
104-
log("Failed to establish AsyncChannel connection");
105-
}
106-
break;
107-
default:
108-
//Ignore
109-
break;
110-
}
111-
}
112-
}
113-
11494
private void printNetworkConfigurations() {
11595
log("==== print network configurations parsed from XML file ====");
11696
log("number of access points: " + networks.size());

core/tests/bandwidthtests/src/com/android/bandwidthtest/util/ConnectionUtil.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,6 @@ public class ConnectionUtil {
7474
private int mWifiState;
7575
private NetworkInfo mWifiNetworkInfo;
7676
private WifiManager mWifiManager;
77-
private WifiManager.Channel mChannel;
7877
private Context mContext;
7978
// Verify connectivity state
8079
private static final int NUM_NETWORK_TYPES = ConnectivityManager.MAX_NETWORK_TYPE + 1;
@@ -115,7 +114,6 @@ public void initialize() throws Exception {
115114

116115
// Get an instance of WifiManager
117116
mWifiManager =(WifiManager)mContext.getSystemService(Context.WIFI_SERVICE);
118-
mChannel = mWifiManager.initialize(mContext, mContext.getMainLooper(), null);
119117

120118
mDownloadManager = (DownloadManager)mContext.getSystemService(Context.DOWNLOAD_SERVICE);
121119

@@ -574,7 +572,7 @@ public boolean connectToWifiWithConfiguration(WifiConfiguration config) {
574572
Log.v(LOG_TAG, "Found " + ssid + " in the scan result list.");
575573
Log.v(LOG_TAG, "Retry: " + retry);
576574
foundApInScanResults = true;
577-
mWifiManager.connect(mChannel, config, new WifiManager.ActionListener() {
575+
mWifiManager.connect(config, new WifiManager.ActionListener() {
578576
public void onSuccess() {
579577
}
580578
public void onFailure(int reason) {
@@ -628,7 +626,7 @@ public boolean disconnectAP() {
628626
for (WifiConfiguration wifiConfig: wifiConfigList) {
629627
Log.v(LOG_TAG, "Remove wifi configuration: " + wifiConfig.networkId);
630628
int netId = wifiConfig.networkId;
631-
mWifiManager.forget(mChannel, netId, new WifiManager.ActionListener() {
629+
mWifiManager.forget(netId, new WifiManager.ActionListener() {
632630
public void onSuccess() {
633631
}
634632
public void onFailure(int reason) {

0 commit comments

Comments
 (0)