Don't set keyboard insets if keyboard is hidden.

Craig Mautner · Craig Mautner · commit 8bd206b54872 · 2012-10-03T10:32:02.000-07:00
Makes sense.

Bug: 7256294 fixed.
Change-Id: I435fc2e6e5acdf5c4d70b9dad1a30d7fe7c11b31
diff --git a/policy/src/com/android/internal/policy/impl/PhoneWindowManager.java b/policy/src/com/android/internal/policy/impl/PhoneWindowManager.java
@@ -2826,7 +2826,8 @@ public void layoutWindowLw(WindowState win, WindowManager.LayoutParams attrs,
 
         // Dock windows carve out the bottom of the screen, so normal windows
         // can't appear underneath them.
-        if (attrs.type == TYPE_INPUT_METHOD && !win.getGivenInsetsPendingLw()) {
+        if (attrs.type == TYPE_INPUT_METHOD && win.isVisibleOrBehindKeyguardLw()
+                && !win.getGivenInsetsPendingLw()) {
             setLastInputMethodWindowLw(null, null);
             offsetInputMethodWindowLw(win);
         }

Original file line number	Diff line number	Diff line change
`@@ -2826,7 +2826,8 @@ public void layoutWindowLw(WindowState win, WindowManager.LayoutParams attrs,`
`2826`	`2826`
`2827`	`2827`	`// Dock windows carve out the bottom of the screen, so normal windows`
`2828`	`2828`	`// can't appear underneath them.`
`2829`		`- if (attrs.type == TYPE_INPUT_METHOD && !win.getGivenInsetsPendingLw()) {`
	`2829`	`+ if (attrs.type == TYPE_INPUT_METHOD && win.isVisibleOrBehindKeyguardLw()`
	`2830`	`+ && !win.getGivenInsetsPendingLw()) {`
`2830`	`2831`	`setLastInputMethodWindowLw(null, null);`
`2831`	`2832`	`offsetInputMethodWindowLw(win);`
`2832`	`2833`	`}`