Skip to content

Commit 8df3889

Browse files
marconeAndroid (Google) Code Review
authored andcommitted
Merge "Log a warning when a MediaPlayer is finalized without having being released. b/5382634"
2 parents 9a3d51e + 8dc2084 commit 8df3889

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

media/jni/android_media_MediaPlayer.cpp

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -651,6 +651,10 @@ static void
651651
android_media_MediaPlayer_native_finalize(JNIEnv *env, jobject thiz)
652652
{
653653
LOGV("native_finalize");
654+
sp<MediaPlayer> mp = getMediaPlayer(env, thiz);
655+
if (mp != NULL) {
656+
LOGW("MediaPlayer finalized without being released");
657+
}
654658
android_media_MediaPlayer_release(env, thiz);
655659
}
656660

0 commit comments

Comments
 (0)