Skip to content

Commit 94ef9df

Browse files
author
Craig Mautner
committed
Fix flashy transition in QuickContacts
Calls to relayout were forcing outgoing app reported visibility to false. Because there was a DummyAnimation in the outgoing app the stepAnimation was forcing the app Transformation alpha value to 0 based on the most recent reportedVisibile value. This was causing the outgoing app to disappear for an instant. Moving the visibility test to the time at which the DummyAnimation is set fixes this problem. Fixes bug 5908102. Change-Id: Ib574728a007a0af759990816db42e23ba315b468
1 parent d51f90f commit 94ef9df

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

services/java/com/android/server/wm/AppWindowAnimator.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,9 @@ public void setDummyAnimation() {
8585
animation = sDummyAnimation;
8686
animInitialized = false;
8787
}
88+
hasTransformation = true;
89+
transformation.clear();
90+
transformation.setAlpha(mAppToken.reportedVisible ? 1 : 0);
8891
}
8992

9093
public void clearAnimation() {
@@ -186,8 +189,6 @@ boolean stepAnimationLocked(long currentTime, int dw, int dh) {
186189
// it as not animating for purposes of scheduling transactions;
187190
// when it is really time to animate, this will be set to
188191
// a real animation and the next call will execute normally.
189-
hasTransformation = true;
190-
transformation.setAlpha(mAppToken.reportedVisible ? 1 : 0);
191192
return false;
192193
}
193194

0 commit comments

Comments
 (0)