Skip to content

Commit 98ba894

Browse files
author
Romain Guy
committed
Make gradients look slightly better
Change-Id: Ib12c628a88b9ec6af1214ce6e5cb14cfde40485e
1 parent 00755fe commit 98ba894

File tree

3 files changed

+61
-2
lines changed

3 files changed

+61
-2
lines changed

libs/hwui/GradientCache.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ Texture* GradientCache::addLinearGradient(GradientCacheEntry& gradient,
120120
width = width < mMaxTextureSize ? width : mMaxTextureSize;
121121

122122
SkBitmap bitmap;
123-
bitmap.setConfig(SkBitmap::kARGB_8888_Config, width, 1);
123+
bitmap.setConfig(SkBitmap::kARGB_8888_Config, width, 4);
124124
bitmap.allocPixels();
125125
bitmap.eraseColor(0);
126126

@@ -137,7 +137,7 @@ Texture* GradientCache::addLinearGradient(GradientCacheEntry& gradient,
137137
p.setStyle(SkPaint::kStrokeAndFill_Style);
138138
p.setShader(localShader)->unref();
139139

140-
canvas.drawRectCoords(0.0f, 0.0f, bitmap.width(), 1.0f, p);
140+
canvas.drawRectCoords(0.0f, 0.0f, bitmap.width(), 4.0f, p);
141141

142142
// Asume the cache is always big enough
143143
const uint32_t size = bitmap.rowBytes() * bitmap.height();

tests/HwAccelerationTest/AndroidManifest.xml

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,15 @@
4141
</intent-filter>
4242
</activity>
4343

44+
<activity
45+
android:name="BigGradientActivity"
46+
android:label="_BigGradient">
47+
<intent-filter>
48+
<action android:name="android.intent.action.MAIN" />
49+
<category android:name="android.intent.category.LAUNCHER" />
50+
</intent-filter>
51+
</activity>
52+
4453
<activity
4554
android:name="DatePickerActivity"
4655
android:label="_DatePicker">
Lines changed: 50 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,50 @@
1+
/*
2+
* Copyright (C) 2012 The Android Open Source Project
3+
*
4+
* Licensed under the Apache License, Version 2.0 (the "License");
5+
* you may not use this file except in compliance with the License.
6+
* You may obtain a copy of the License at
7+
*
8+
* http://www.apache.org/licenses/LICENSE-2.0
9+
*
10+
* Unless required by applicable law or agreed to in writing, software
11+
* distributed under the License is distributed on an "AS IS" BASIS,
12+
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13+
* See the License for the specific language governing permissions and
14+
* limitations under the License.
15+
*/
16+
17+
package com.android.test.hwui;
18+
19+
import android.app.Activity;
20+
import android.content.Context;
21+
import android.graphics.Canvas;
22+
import android.graphics.LinearGradient;
23+
import android.graphics.Paint;
24+
import android.graphics.Shader;
25+
import android.os.Bundle;
26+
import android.view.View;
27+
28+
public class BigGradientActivity extends Activity {
29+
@Override
30+
protected void onCreate(Bundle savedInstanceState) {
31+
super.onCreate(savedInstanceState);
32+
33+
setContentView(new BigGradientView(this));
34+
}
35+
36+
private class BigGradientView extends View {
37+
public BigGradientView(Context context) {
38+
super(context);
39+
}
40+
41+
@Override
42+
protected void onDraw(Canvas canvas) {
43+
Paint p = new Paint();
44+
p.setShader(new LinearGradient(0.0f, 0.0f, 0.0f, getHeight(), 0xff000000,
45+
0xff333333, Shader.TileMode.CLAMP));
46+
47+
canvas.drawRect(0.0f, 0.0f, getWidth(), getHeight(), p);
48+
}
49+
}
50+
}

0 commit comments

Comments
 (0)