The x and y position of the pop-up where not calculated correctly when the text view had internal scrolling.

Luca Zanolin · Luca Zanolin · commit a403cb7e721a · 2011-09-28T11:43:22.000+01:00
This method is invoked only when the pop-up is currently displayed and the text scrolles.

This is scenario is reproducible only with Voice IME (I think), as the text is inserted without
touching the screen.

Bug: 5290463

Change-Id: I0b842732cc1f115de06e992fbe28cb64eac49b22
diff --git a/core/java/android/widget/TextView.java b/core/java/android/widget/TextView.java
@@ -9433,8 +9433,8 @@ public boolean isVisible(int positionX, int positionY) {
                 return false;
             }
 
-            int posX = mPositionX + positionX;
-            int posY = mPositionY + positionY;
+            int posX = mPositionX + positionX - getScrollX();
+            int posY = mPositionY + positionY - getScrollY();
 
             // Offset by 1 to take into account 0.5 and int rounding around getPrimaryHorizontal.
             return posX >= clip.left - 1 && posX <= clip.right + 1 &&

Original file line number	Diff line number	Diff line change
`@@ -9433,8 +9433,8 @@ public boolean isVisible(int positionX, int positionY) {`
`9433`	`9433`	`return false;`
`9434`	`9434`	`}`
`9435`	`9435`
`9436`		`- int posX = mPositionX + positionX;`
`9437`		`- int posY = mPositionY + positionY;`
	`9436`	`+ int posX = mPositionX + positionX - getScrollX();`
	`9437`	`+ int posY = mPositionY + positionY - getScrollY();`
`9438`	`9438`
`9439`	`9439`	`// Offset by 1 to take into account 0.5 and int rounding around getPrimaryHorizontal.`
`9440`	`9440`	`return posX >= clip.left - 1 && posX <= clip.right + 1 &&`