Skip to content

Commit a76f823

Browse files
ChrisCraikAndroid (Google) Code Review
authored andcommitted
Merge "Fix locking for skip draw" into jb-dev
2 parents 0fa1529 + 55c68f1 commit a76f823

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

core/java/android/webkit/WebViewCore.java

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2176,19 +2176,20 @@ static class DrawData {
21762176

21772177
DrawData mLastDrawData = null;
21782178

2179-
private Boolean m_skipDrawFlag = false;
2179+
private Object m_skipDrawFlagLock = new Object();
2180+
private boolean m_skipDrawFlag = false;
21802181
private boolean m_drawWasSkipped = false;
21812182

21822183
void pauseWebKitDraw() {
2183-
synchronized (m_skipDrawFlag) {
2184+
synchronized (m_skipDrawFlagLock) {
21842185
if (!m_skipDrawFlag) {
21852186
m_skipDrawFlag = true;
21862187
}
21872188
}
21882189
}
21892190

21902191
void resumeWebKitDraw() {
2191-
synchronized (m_skipDrawFlag) {
2192+
synchronized (m_skipDrawFlagLock) {
21922193
if (m_skipDrawFlag && m_drawWasSkipped) {
21932194
// a draw was dropped, send a retry
21942195
m_drawWasSkipped = false;
@@ -2199,7 +2200,7 @@ void resumeWebKitDraw() {
21992200
}
22002201

22012202
private void webkitDraw() {
2202-
synchronized (m_skipDrawFlag) {
2203+
synchronized (m_skipDrawFlagLock) {
22032204
if (m_skipDrawFlag) {
22042205
m_drawWasSkipped = true;
22052206
return;

0 commit comments

Comments
 (0)