Skip to content

Commit aa99729

Browse files
ChrisCraikAndroid (Google) Code Review
authored andcommitted
Merge "Revert "Add temporary functor lifetime logging"" into jb-dev
2 parents 59f3f58 + 12d434a commit aa99729

File tree

2 files changed

+2
-10
lines changed

2 files changed

+2
-10
lines changed

core/java/android/webkit/WebViewClassic.java

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -2000,11 +2000,6 @@ public void destroy() {
20002000
}
20012001

20022002
private void destroyImpl() {
2003-
int drawGLFunction = nativeGetDrawGLFunction(mNativeClass);
2004-
ViewRootImpl viewRoot = mWebView.getViewRootImpl();
2005-
Log.d(LOGTAG, String.format("destroyImpl, drawGLFunction %x, viewroot == null %b, isHWAccel %b",
2006-
drawGLFunction, (viewRoot == null), mWebView.isHardwareAccelerated()));
2007-
20082003
mCallbackProxy.blockMessages();
20092004
clearHelpers();
20102005
if (mListBoxDialog != null) {
@@ -5392,11 +5387,9 @@ public void onDetachedFromWindow() {
53925387
removeAccessibilityApisFromJavaScript();
53935388
updateHwAccelerated();
53945389

5395-
int drawGLFunction = nativeGetDrawGLFunction(mNativeClass);
5396-
ViewRootImpl viewRoot = mWebView.getViewRootImpl();
5397-
Log.d(LOGTAG, String.format("onDetachedFromWindow, drawGLFunction %x, viewroot == null %b, isHWAccel %b",
5398-
drawGLFunction, (viewRoot == null), mWebView.isHardwareAccelerated()));
53995390
if (mWebView.isHardwareAccelerated()) {
5391+
int drawGLFunction = nativeGetDrawGLFunction(mNativeClass);
5392+
ViewRootImpl viewRoot = mWebView.getViewRootImpl();
54005393
if (drawGLFunction != 0 && viewRoot != null) {
54015394
viewRoot.detachFunctor(drawGLFunction);
54025395
}

libs/hwui/OpenGLRenderer.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -247,7 +247,6 @@ void OpenGLRenderer::resume() {
247247
}
248248

249249
void OpenGLRenderer::detachFunctor(Functor* functor) {
250-
ALOGD("OGLR %p detachFunctor %p", this, functor);
251250
mFunctors.remove(functor);
252251
}
253252

0 commit comments

Comments
 (0)