Skip to content

Commit b46f3f6

Browse files
cwrenAndroid (Google) Code Review
authored andcommitted
Merge "Defensively reset the default state of layout elements." into jb-dev
2 parents a0e0d58 + 67dc9a0 commit b46f3f6

File tree

1 file changed

+8
-0
lines changed

1 file changed

+8
-0
lines changed

core/java/android/app/Notification.java

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1637,15 +1637,21 @@ protected RemoteViews getStandardView(int layoutId) {
16371637

16381638
if (mBuilder.mSubText == null) {
16391639
contentView.setViewVisibility(R.id.line3, View.GONE);
1640+
} else {
1641+
contentView.setViewVisibility(R.id.line3, View.VISIBLE);
16401642
}
16411643

16421644
if (mBigContentTitle != null && mBigContentTitle.equals("")) {
16431645
contentView.setViewVisibility(R.id.line1, View.GONE);
1646+
} else {
1647+
contentView.setViewVisibility(R.id.line1, View.VISIBLE);
16441648
}
16451649

16461650
if (mSummaryText != null && !mSummaryText.equals("")) {
16471651
contentView.setViewVisibility(R.id.overflow_title, View.VISIBLE);
16481652
contentView.setTextViewText(R.id.overflow_title, mSummaryText);
1653+
} else {
1654+
contentView.setViewVisibility(R.id.overflow_title, View.GONE);
16491655
}
16501656

16511657
return contentView;
@@ -1852,6 +1858,8 @@ private RemoteViews makeBigContentView() {
18521858
if (str != null && !str.equals("")) {
18531859
contentView.setViewVisibility(rowIds[i], View.VISIBLE);
18541860
contentView.setTextViewText(rowIds[i], str);
1861+
} else {
1862+
contentView.setViewVisibility(rowIds[i], View.GONE);
18551863
}
18561864
i++;
18571865
}

0 commit comments

Comments
 (0)