Skip to content

Commit bcf05a6

Browse files
author
Fabrice Di Meglio
committed
Fix bug #5553401 TextLayoutCache is too verbose: "computeValuesWithHarfbuzz -- need to force to single run"
- make single run case non verbose Change-Id: I5c3b87aeb613697233290ddecac3ca00f58f8313
1 parent d5b25ec commit bcf05a6

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

core/jni/android/graphics/TextLayoutCache.cpp

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -444,7 +444,11 @@ void TextLayoutCacheValue::computeValuesWithHarfbuzz(SkPaint* paint, const UChar
444444
LOGD("computeValuesWithHarfbuzz -- dirFlags=%d run-count=%d paraDir=%d",
445445
dirFlags, rc, paraDir);
446446
#endif
447-
if (!U_SUCCESS(status) || rc <= 1) {
447+
if (U_SUCCESS(status) && rc == 1) {
448+
// Normal case: one run, status is ok
449+
isRTL = (paraDir == 1);
450+
useSingleRun = true;
451+
} else if (!U_SUCCESS(status) || rc < 1) {
448452
LOGW("computeValuesWithHarfbuzz -- need to force to single run");
449453
isRTL = (paraDir == 1);
450454
useSingleRun = true;

0 commit comments

Comments
 (0)