AccessibilityNodeInfo makes incorrect check before calling into the system.

sganov · sganov · commit c0291bb2eb96 · 2011-10-26T14:37:46.000-07:00
AccessibilityNodeInfo#getParent is checking whether the source view
accessibility id is specified instead that of the parent.

bug:5505799

Change-Id: I436fd2327def2762b4d307819ba0c23baa9a4e03
diff --git a/core/java/android/view/accessibility/AccessibilityNodeInfo.java b/core/java/android/view/accessibility/AccessibilityNodeInfo.java
@@ -293,7 +293,7 @@ public List<AccessibilityNodeInfo> findAccessibilityNodeInfosByText(String text)
      */
     public AccessibilityNodeInfo getParent() {
         enforceSealed();
-        if (!canPerformRequestOverConnection(mAccessibilityViewId)) {
+        if (!canPerformRequestOverConnection(mParentAccessibilityViewId)) {
             return null;
         }
         AccessibilityInteractionClient client = AccessibilityInteractionClient.getInstance();

Original file line number	Diff line number	Diff line change
`@@ -293,7 +293,7 @@ public List<AccessibilityNodeInfo> findAccessibilityNodeInfosByText(String text)`
`293`	`293`	`*/`
`294`	`294`	`public AccessibilityNodeInfo getParent() {`
`295`	`295`	`enforceSealed();`
`296`		`- if (!canPerformRequestOverConnection(mAccessibilityViewId)) {`
	`296`	`+ if (!canPerformRequestOverConnection(mParentAccessibilityViewId)) {`
`297`	`297`	`return null;`
`298`	`298`	`}`
`299`	`299`	`AccessibilityInteractionClient client = AccessibilityInteractionClient.getInstance();`