Removing callbacks in onDetachedFromWindow, fixes b/7465673

Danielle Millett · Danielle Millett · commit cade0049a729 · 2012-11-06T14:18:59.000-05:00
In certain cases when lockscreen is constructed in landscape and then
switches to portrait on the phone, it inflates new views for
KeyguardHostView.  The old views never call onPause() in KeyguardFaceUnlockView
so it was still getting callbacks and starting Face Unlock multiple
times.  By removing the callbacks in onDetachedFromWindow() there won't be
multiple instances of KeyguardFaceUnlockView receiving callbacks and
starting face unlock.

Change-Id: I00d770283e83be2f4b76e00340123789a8075091
diff --git a/policy/src/com/android/internal/policy/impl/keyguard/KeyguardFaceUnlockView.java b/policy/src/com/android/internal/policy/impl/keyguard/KeyguardFaceUnlockView.java
@@ -90,6 +90,7 @@ public void onDetachedFromWindow() {
         if (mBiometricUnlock != null) {
             mBiometricUnlock.stop();
         }
+        KeyguardUpdateMonitor.getInstance(mContext).removeCallback(mUpdateCallback);
     }
 
     @Override

Original file line number	Diff line number	Diff line change
`@@ -90,6 +90,7 @@ public void onDetachedFromWindow() {`
`90`	`90`	`if (mBiometricUnlock != null) {`
`91`	`91`	`mBiometricUnlock.stop();`
`92`	`92`	`}`
	`93`	`+ KeyguardUpdateMonitor.getInstance(mContext).removeCallback(mUpdateCallback);`
`93`	`94`	`}`
`94`	`95`
`95`	`96`	`@Override`