Skip to content

Commit dad52e1

Browse files
adampAndroid (Google) Code Review
authored andcommitted
Merge "Better screen size adaptation for ResolverActivity" into jb-dev
2 parents 8fb6232 + 589e6f9 commit dad52e1

File tree

6 files changed

+39
-7
lines changed

6 files changed

+39
-7
lines changed

core/java/com/android/internal/app/ResolverActivity.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -70,8 +70,7 @@ public class ResolverActivity extends AlertActivity implements AdapterView.OnIte
7070
private Button mOnceButton;
7171
private int mIconDpi;
7272
private int mIconSize;
73-
74-
private static final int MAX_COLUMNS = 4;
73+
private int mMaxColumns;
7574

7675
private boolean mRegistered;
7776
private final PackageMonitor mPackageMonitor = new PackageMonitor() {
@@ -105,6 +104,7 @@ protected void onCreate(Bundle savedInstanceState, Intent intent,
105104
super.onCreate(savedInstanceState);
106105
mPm = getPackageManager();
107106
mAlwaysUseOption = alwaysUseOption;
107+
mMaxColumns = getResources().getInteger(R.integer.config_maxResolverActivityColumns);
108108
intent.setComponent(null);
109109

110110
AlertController.AlertParams ap = mAlertParams;
@@ -154,7 +154,7 @@ protected void onCreate(Bundle savedInstanceState, Intent intent,
154154

155155
void resizeGrid() {
156156
final int itemCount = mAdapter.getCount();
157-
mGrid.setNumColumns(Math.min(itemCount, MAX_COLUMNS));
157+
mGrid.setNumColumns(Math.min(itemCount, mMaxColumns));
158158
}
159159

160160
Drawable getIcon(Resources res, int resId) {

core/res/res/layout/resolve_list_item.xml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,8 @@
3333
android:gravity="center"
3434
android:minLines="2"
3535
android:maxLines="2"
36-
android:paddingLeft="8dip"
37-
android:paddingRight="8dip" />
36+
android:paddingLeft="4dip"
37+
android:paddingRight="4dip" />
3838

3939
<!-- Activity icon when presenting dialog
4040
Size will be filled in by ResolverActivity -->
@@ -51,7 +51,7 @@
5151
android:gravity="center"
5252
android:minLines="2"
5353
android:maxLines="2"
54-
android:paddingLeft="8dip"
55-
android:paddingRight="8dip" />
54+
android:paddingLeft="4dip"
55+
android:paddingRight="4dip" />
5656
</LinearLayout>
5757

core/res/res/values-sw600dp/config.xml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,5 +35,10 @@
3535
<!-- If true, the screen can be rotated via the accelerometer in all 4
3636
rotations as the default behavior. -->
3737
<bool name="config_allowAllRotations">true</bool>
38+
39+
<!-- Maximum number of grid columns permitted in the ResolverActivity
40+
used for picking activities to handle an intent. -->
41+
<integer name="config_maxResolverActivityColumns">3</integer>
42+
3843
</resources>
3944

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
<?xml version="1.0" encoding="utf-8"?>
2+
<!-- Copyright (C) 2012 The Android Open Source Project
3+
4+
Licensed under the Apache License, Version 2.0 (the "License");
5+
you may not use this file except in compliance with the License.
6+
You may obtain a copy of the License at
7+
8+
http://www.apache.org/licenses/LICENSE-2.0
9+
10+
Unless required by applicable law or agreed to in writing, software
11+
distributed under the License is distributed on an "AS IS" BASIS,
12+
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13+
See the License for the specific language governing permissions and
14+
limitations under the License.
15+
-->
16+
<resources>
17+
18+
<!-- Maximum number of grid columns permitted in the ResolverActivity
19+
used for picking activities to handle an intent. -->
20+
<integer name="config_maxResolverActivityColumns">4</integer>
21+
22+
</resources>

core/res/res/values/config.xml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -846,6 +846,10 @@
846846
movement threshold where scrolling should begin. -->
847847
<dimen name="config_viewConfigurationTouchSlop">8dp</dimen>
848848

849+
<!-- Maximum number of grid columns permitted in the ResolverActivity
850+
used for picking activities to handle an intent. -->
851+
<integer name="config_maxResolverActivityColumns">2</integer>
852+
849853
<!-- Array of OEM specific USB mode override config.
850854
OEM can override a certain USB mode depending on ro.bootmode.
851855
Specify an array of below items to set override rule.

core/res/res/values/public.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1512,6 +1512,7 @@
15121512
<java-symbol type="id" name="resolver_grid" />
15131513
<java-symbol type="id" name="button_once" />
15141514
<java-symbol type="id" name="button_always" />
1515+
<java-symbol type="integer" name="config_maxResolverActivityColumns" />
15151516

15161517
<!-- From SystemUI -->
15171518
<java-symbol type="anim" name="push_down_in" />

0 commit comments

Comments
 (0)