Skip to content

Commit df0c2a9

Browse files
sj0110.kim@samsung.com(sophia kim)Jake Hamby
authored andcommitted
Change DCS of MO SMS to the correct value for UCS-2 encoding.
An incorrect value for TP-Data-Coding-Scheme was used for MO SMS with UCS-2 encoding. According to 3GPP TS 23.038 section 4, when bit 4 is set to 0, bits 0 and 1 are reserved and have no message class meaning. We were setting those bits to 1, when they should be set to 0. This change is required to pass a GCF test case. Change-Id: If47361f95b0e14accc6220854783dcff3d82abf6
1 parent f0f7a91 commit df0c2a9

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

telephony/java/com/android/internal/telephony/gsm/SmsMessage.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -300,8 +300,8 @@ public static SubmitPdu getSubmitPdu(String scAddress,
300300
return null;
301301
}
302302
// TP-Data-Coding-Scheme
303-
// Class 3, UCS-2 encoding, uncompressed
304-
bo.write(0x0b);
303+
// UCS-2 encoding, uncompressed
304+
bo.write(0x08);
305305
}
306306

307307
// (no TP-Validity-Period)

0 commit comments

Comments
 (0)