Skip to content

Commit e5febfd

Browse files
satok16Android (Google) Code Review
authored andcommitted
Merge "Clean up the spell checker framework" into ics-mr1
2 parents f52a448 + 060677f commit e5febfd

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

core/java/android/view/textservice/SpellCheckerSession.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -201,7 +201,7 @@ private static class SpellCheckerSessionListenerImpl extends ISpellCheckerSessio
201201
private static final int TASK_CLOSE = 3;
202202
private final Queue<SpellCheckerParams> mPendingTasks =
203203
new LinkedList<SpellCheckerParams>();
204-
private final Handler mHandler;
204+
private Handler mHandler;
205205

206206
private boolean mOpened;
207207
private ISpellCheckerSession mISpellCheckerSession;
@@ -334,6 +334,7 @@ private void processClose() {
334334
try {
335335
mISpellCheckerSession.onClose();
336336
mISpellCheckerSession = null;
337+
mHandler = null;
337338
} catch (RemoteException e) {
338339
Log.e(TAG, "Failed to close " + e);
339340
}

services/java/com/android/server/TextServicesManagerService.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -360,7 +360,7 @@ private void startSpellCheckerServiceInnerLocked(SpellCheckerInfo info, String l
360360
}
361361
final String sciId = info.getId();
362362
final InternalServiceConnection connection = new InternalServiceConnection(
363-
sciId, locale, scListener, bundle);
363+
sciId, locale, bundle);
364364
final Intent serviceIntent = new Intent(SpellCheckerService.SERVICE_INTERFACE);
365365
serviceIntent.setComponent(info.getComponent());
366366
if (DBG) {
@@ -704,15 +704,13 @@ public void removeAll() {
704704
}
705705

706706
private class InternalServiceConnection implements ServiceConnection {
707-
private final ISpellCheckerSessionListener mListener;
708707
private final String mSciId;
709708
private final String mLocale;
710709
private final Bundle mBundle;
711710
public InternalServiceConnection(
712-
String id, String locale, ISpellCheckerSessionListener listener, Bundle bundle) {
711+
String id, String locale, Bundle bundle) {
713712
mSciId = id;
714713
mLocale = locale;
715-
mListener = listener;
716714
mBundle = bundle;
717715
}
718716

0 commit comments

Comments
 (0)