Skip to content

Commit f18222d

Browse files
Yu Shan Emily LauAndroid (Google) Code Review
authored andcommitted
Merge "Fix the test cases which fail to launch the camera in the device which only has one camera." into jb-dev
2 parents ccdf0af + e35b3e0 commit f18222d

File tree

5 files changed

+14
-7
lines changed

5 files changed

+14
-7
lines changed

media/tests/MediaFrameworkTest/src/com/android/mediaframeworktest/functional/CameraTest.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@ public class CameraTest extends ActivityInstrumentationTestCase<MediaFrameworkTe
4747
private boolean jpegPictureCallbackResult = false;
4848

4949
private static int WAIT_FOR_COMMAND_TO_COMPLETE = 10000; // Milliseconds.
50+
private static final int CAMERA_ID = 0;
5051

5152
private RawPreviewCallback mRawPreviewCallback = new RawPreviewCallback();
5253
private TestShutterCallback mShutterCallback = new TestShutterCallback();
@@ -85,7 +86,7 @@ public void run() {
8586
// Save the looper so that we can terminate this thread
8687
// after we are done with it.
8788
mLooper = Looper.myLooper();
88-
mCamera = Camera.open();
89+
mCamera = Camera.open(CAMERA_ID);
8990
startDone.open();
9091
Looper.loop(); // Blocks forever until Looper.quit() is called.
9192
Log.v(TAG, "initializeMessageLooper: quit.");

media/tests/MediaFrameworkTest/src/com/android/mediaframeworktest/functional/mediarecorder/MediaRecorderTest.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,8 @@ public class MediaRecorderTest extends ActivityInstrumentationTestCase2<MediaFra
5454

5555
private int MIN_VIDEO_FPS = 5;
5656

57+
private static final int CAMERA_ID = 0;
58+
5759
Context mContext;
5860
Camera mCamera;
5961

@@ -247,7 +249,7 @@ private boolean validateVideo(String filePath, int width, int height) {
247249
public void testPortraitH263() throws Exception {
248250
boolean videoRecordedResult = false;
249251
try {
250-
mCamera = Camera.open();
252+
mCamera = Camera.open(CAMERA_ID);
251253
Camera.Parameters parameters = mCamera.getParameters();
252254
parameters.setPreviewSize(352, 288);
253255
parameters.set("orientation", "portrait");

media/tests/MediaFrameworkTest/src/com/android/mediaframeworktest/performance/MediaPlayerPerformance.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,7 @@ public class MediaPlayerPerformance extends ActivityInstrumentationTestCase2<Med
7272
"/sdcard/mediaMemOutput.txt";
7373
private static final String MEDIA_PROCMEM_OUTPUT =
7474
"/sdcard/mediaProcmemOutput.txt";
75+
private static final int CAMERA_ID = 0;
7576

7677
private static int mStartMemory = 0;
7778
private static int mEndMemory = 0;
@@ -132,7 +133,7 @@ public void run() {
132133
Looper.prepare();
133134
Log.v(TAG, "start loopRun");
134135
mLooper = Looper.myLooper();
135-
mCamera = Camera.open();
136+
mCamera = Camera.open(CAMERA_ID);
136137
startDone.open();
137138
Looper.loop();
138139
Log.v(TAG, "initializeMessageLooper: quit.");

media/tests/MediaFrameworkTest/src/com/android/mediaframeworktest/stress/CameraStressTest.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,7 @@ public class CameraStressTest extends ActivityInstrumentationTestCase2<MediaFram
6060
private static final long WAIT_ZOOM_ANIMATION = 5 * 1000; // 5 seconds
6161
private static final String CAMERA_STRESS_OUTPUT =
6262
"/sdcard/cameraStressOutput.txt";
63+
private static final int CAMERA_ID = 0;
6364
private final CameraErrorCallback mCameraErrorCallback = new CameraErrorCallback();
6465

6566
private Thread mLooperThread;
@@ -213,7 +214,7 @@ public void testStressCameraZoom() throws Exception {
213214
Log.v(TAG, "Start preview");
214215
output.write("No of loop: ");
215216

216-
mCamera = Camera.open();
217+
mCamera = Camera.open(CAMERA_ID);
217218
Camera.Parameters params = mCamera.getParameters();
218219
mCamera.release();
219220

@@ -230,7 +231,7 @@ public void testStressCameraZoom() throws Exception {
230231
runOnLooper(new Runnable() {
231232
@Override
232233
public void run() {
233-
mCamera = Camera.open();
234+
mCamera = Camera.open(CAMERA_ID);
234235
}
235236
});
236237

media/tests/MediaFrameworkTest/src/com/android/mediaframeworktest/stress/MediaRecorderStressTest.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,8 @@ public class MediaRecorderStressTest extends ActivityInstrumentationTestCase2<Me
6060
private static final String OUTPUT_FILE_EXT = ".3gp";
6161
private static final String MEDIA_STRESS_OUTPUT =
6262
"/sdcard/mediaStressOutput.txt";
63+
private static final int CAMERA_ID = 0;
64+
6365
private final CameraErrorCallback mCameraErrorCallback = new CameraErrorCallback();
6466
private final RecorderErrorCallback mRecorderErrorCallback = new RecorderErrorCallback();
6567

@@ -162,7 +164,7 @@ public void testStressCamera() throws Exception {
162164
runOnLooper(new Runnable() {
163165
@Override
164166
public void run() {
165-
mCamera = Camera.open();
167+
mCamera = Camera.open(CAMERA_ID);
166168
}
167169
});
168170
mCamera.setErrorCallback(mCameraErrorCallback);
@@ -250,7 +252,7 @@ public void testStressCameraSwitchRecorder() throws Exception {
250252
runOnLooper(new Runnable() {
251253
@Override
252254
public void run() {
253-
mCamera = Camera.open();
255+
mCamera = Camera.open(CAMERA_ID);
254256
}
255257
});
256258
mCamera.setErrorCallback(mCameraErrorCallback);

0 commit comments

Comments
 (0)