Skip to content

Commit f4a502a

Browse files
mikeandroidAndroid (Google) Code Review
authored andcommitted
Merge "Don't adjust lights if screen or button brightness is changed when the screen is off." into froyo
2 parents 8f2ca78 + f527c71 commit f4a502a

File tree

1 file changed

+8
-2
lines changed

1 file changed

+8
-2
lines changed

services/java/com/android/server/PowerManagerService.java

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1342,21 +1342,27 @@ public void preventScreenOn(boolean prevent) {
13421342
public void setScreenBrightnessOverride(int brightness) {
13431343
mContext.enforceCallingOrSelfPermission(android.Manifest.permission.DEVICE_POWER, null);
13441344

1345+
if (mSpew) Slog.d(TAG, "setScreenBrightnessOverride " + brightness);
13451346
synchronized (mLocks) {
13461347
if (mScreenBrightnessOverride != brightness) {
13471348
mScreenBrightnessOverride = brightness;
1348-
updateLightsLocked(mPowerState, SCREEN_ON_BIT);
1349+
if (isScreenOn()) {
1350+
updateLightsLocked(mPowerState, SCREEN_ON_BIT);
1351+
}
13491352
}
13501353
}
13511354
}
13521355

13531356
public void setButtonBrightnessOverride(int brightness) {
13541357
mContext.enforceCallingOrSelfPermission(android.Manifest.permission.DEVICE_POWER, null);
13551358

1359+
if (mSpew) Slog.d(TAG, "setButtonBrightnessOverride " + brightness);
13561360
synchronized (mLocks) {
13571361
if (mButtonBrightnessOverride != brightness) {
13581362
mButtonBrightnessOverride = brightness;
1359-
updateLightsLocked(mPowerState, BUTTON_BRIGHT_BIT | KEYBOARD_BRIGHT_BIT);
1363+
if (isScreenOn()) {
1364+
updateLightsLocked(mPowerState, BUTTON_BRIGHT_BIT | KEYBOARD_BRIGHT_BIT);
1365+
}
13601366
}
13611367
}
13621368
}

0 commit comments

Comments
 (0)