Skip to content

Commit f6468ca

Browse files
Jonathan DixonAndroid (Google) Code Review
authored andcommitted
Merge "Remove deprecated methods from webview provider interface"
2 parents 0b8bd49 + 19274f5 commit f6468ca

File tree

3 files changed

+6
-23
lines changed

3 files changed

+6
-23
lines changed

core/java/android/webkit/WebView.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1550,7 +1550,6 @@ public void refreshPlugins(boolean reloadOpenPages) {
15501550
@Deprecated
15511551
public void emulateShiftHeld() {
15521552
checkThread();
1553-
mProvider.emulateShiftHeld();
15541553
}
15551554

15561555
/**
@@ -1656,7 +1655,6 @@ public boolean zoomOut() {
16561655
@Deprecated
16571656
public void debugDump() {
16581657
checkThread();
1659-
mProvider.debugDump();
16601658
}
16611659

16621660
/**

core/java/android/webkit/WebViewClassic.java

Lines changed: 6 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -3550,7 +3550,8 @@ public WebBackForwardListClassic copyBackForwardList() {
35503550
* See {@link WebView#setFindListener(WebView.FindListener)}.
35513551
* @hide
35523552
*/
3553-
public void setFindListener(WebView.FindListener listener) {
3553+
@Override
3554+
public void setFindListener(WebView.FindListener listener) {
35543555
mFindListener = listener;
35553556
}
35563557

@@ -3573,6 +3574,7 @@ public int findAll(String find) {
35733574
return findAllBody(find, false);
35743575
}
35753576

3577+
@Override
35763578
public void findAllAsync(String find) {
35773579
findAllBody(find, true);
35783580
}
@@ -3611,6 +3613,7 @@ private int findAllBody(String find, boolean isAsync) {
36113613
* If false and text is non-null, perform a find all.
36123614
* @return boolean True if the find dialog is shown, false otherwise.
36133615
*/
3616+
@Override
36143617
public boolean showFindDialog(String text, boolean showIme) {
36153618
FindActionModeCallback callback = new FindActionModeCallback(mContext);
36163619
if (mWebView.getParent() == null || mWebView.startActionMode(callback) == null) {
@@ -5234,14 +5237,6 @@ private void resetCaretTimer() {
52345237
}
52355238
}
52365239

5237-
/**
5238-
* See {@link WebView#emulateShiftHeld()}
5239-
*/
5240-
@Override
5241-
@Deprecated
5242-
public void emulateShiftHeld() {
5243-
}
5244-
52455240
/**
52465241
* Select all of the text in this WebView.
52475242
*
@@ -6487,6 +6482,7 @@ public boolean onGenericMotionEvent(MotionEvent event) {
64876482
private DrawData mDelaySetPicture;
64886483
private DrawData mLoadedPicture;
64896484

6485+
@Override
64906486
public void setMapTrackballToArrowKeys(boolean setMap) {
64916487
mMapTrackballToArrowKeys = setMap;
64926488
}
@@ -6713,6 +6709,7 @@ boolean updateScrollCoordinates(int x, int y) {
67136709
}
67146710
}
67156711

6712+
@Override
67166713
public void flingScroll(int vx, int vy) {
67176714
mScroller.fling(getScrollX(), getScrollY(), vx, vy, 0, computeMaxScrollX(), 0,
67186715
computeMaxScrollY(), mOverflingDistance, mOverflingDistance);
@@ -8450,14 +8447,6 @@ public void setBackgroundColor(int color) {
84508447
mWebViewCore.sendMessage(EventHub.SET_BACKGROUND_COLOR, color);
84518448
}
84528449

8453-
/**
8454-
* See {@link WebView#debugDump()}
8455-
*/
8456-
@Override
8457-
@Deprecated
8458-
public void debugDump() {
8459-
}
8460-
84618450
/**
84628451
* Enable the communication b/t the webView and VideoViewProxy
84638452
*

core/java/android/webkit/WebViewProvider.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -221,8 +221,6 @@ public void loadDataWithBaseURL(String baseUrl, String data,
221221

222222
public WebSettings getSettings();
223223

224-
public void emulateShiftHeld();
225-
226224
public void setMapTrackballToArrowKeys(boolean setMap);
227225

228226
public void flingScroll(int vx, int vy);
@@ -237,8 +235,6 @@ public void loadDataWithBaseURL(String baseUrl, String data,
237235

238236
public boolean zoomOut();
239237

240-
public void debugDump();
241-
242238
public void dumpViewHierarchyWithProperties(BufferedWriter out, int level);
243239

244240
public View findHierarchyView(String className, int hashCode);

0 commit comments

Comments
 (0)