B30.3

[MggMuggins]

Ran my first LOTR overview about 3 hours ago, and it failed relatively miserably. My guess is the overviewer used the wrong minecraft.jar for textures, because I got lots of things like acacia and dark oak doors. Any ideas hub?
~Samwise

[HubTou]

Assuming your diagnostic is correct, did you use a << texturepath = "overviewer_textures-1.7.10-with-lotr.jar" >> line in your Overviewer config and did you explicitely told the Overviewer to use that config file?

As the LotrSupportInOverviewer/Makefile fetches the textures from both the official Minecraft and LOTR mod jars, there could be no mistake (see targets overviewer_textures-1.7.10.jar and The_Lord_of_the_Rings_Mod_B${LOTR_VERSION}.jar).

Else I would need more input to help. Are the results viewable somewhere?

Remember there is no support for beta 30.3+ in LotrSupportInOverviewer/lotr_textures.py.template yet. The tool only knows how to render LOTR blocks up to beta 24.4. Any block above should be rendered as "air" I think. This lotr_textures.py_template file has to be completed with instructions for that.

[MggMuggins]

Will that require a lot of manual work? Basically any block in that render that was supposed to be LOTR was something from 1.8. Could you also provide a specific commit from the overviewer for use with this tool? That would be incredibly helpful.

Texturepath is set to the texture file that this generated when doing make. I also explicitly told it to use config.py (which is a file I made in the same directory as the overviewer). I know it used it, because it threw a few errors the first time I tried to run because I'd done something wrong. Do I need to explicitly need to tell it to use lotr_textures.py.template as well?

On another note, since I've been doing Linux admin for a while, I was able to understand your documentation, but there are some that may be trying to use this that do not. I still spent 6 hours yesterday trying to figure this out. I'll open a pull request to update documentation at some point.

[HubTou]

Hello Sam,

I was able to understand your documentation, but there are some that may be trying to use this that do not. [...] I'll open a pull request to update documentation at some point.

You would be welcome to do so!
The first thing to read is the Makefile.
It is meant to be called one time without arguments ("make"). As can be seen in the "main" target, it will verify pre-requisites, generate a jar file containing both Minecraft 1.7.10 and LOTR Mod textures, and generate a modified Overviewer source file with numerical Blocks ID for the target server (these may vary if other mods are installed).
Then it is meant to be called with the install target ("make install") in order to replace or update the modified Overviewer source file in the server's Overviewer installation.

Do I need to explicitly need to tell it to use lotr_textures.py.template as well?

No. The lotr_textures.py.template file is used to generate a lotr_textures.py file with Blocks ID for the target server, which is then inserted in the existing Overviewer's lotr_textures.py source file. Thus it will be part of the installed Overviewer software and does not have to be referenced.

Will [modifying lotr_textures.py.template] require a lot of manual work?

Basically, you would have:

• to complete the Blocks data values in my Blocks IDs list
• to prepare a test map with all blocks to be rendered (such as this one or that one)
• to check for all assets/lotr/textures/blocks/XXX.png file in the LOTR Mod jar file not supported in lotr_textures.py.template
• to provide code in that template file to render the corresponding blocks imitating what is already there
• to run a modified Overviewer on your test map and see if everything is fine
• to send me a pull request with the updated code :-)

Basically any block in that render that was supposed to be LOTR was something from 1.8. Could you also provide a specific commit from the overviewer for use with this tool? That would be incredibly helpful.

Sorry, I don't understand?

[MggMuggins]

Alright, I'll make two pull requests, one for documentation (I'll get started on that right away), and one for the modified textures file (Later, I'll use diff and other tools to help out with that one).

To clarify, I meant that any block in my render that was supposed to be from LOTR was replaced by some block from 1.8 (for example, we had roads made of dark oak fences, instead of gondor brick). I assume this means that 1.8 stuff was supported by the version of the overviewer that I was using, so I'm wondering if you could find a specific commit on the overviewer repo to use for this tool (A solid, stable 1.7.10 version of the overviewer). Does that make any more sense?

[MggMuggins]

About B31

I'm going to generate the files that you've created for B30 for B31 and add them at a later time. I'd like to wait until we get bugfix updates out. It'll probably be a week or more until I get that completely done. I'll probably forgo the B30 support and move straight to 31.

[MggMuggins]

Basically screw what I said up there, since Mevans doesn't usually change things like that with bugfixes.
I've got the texture lists generated (Just unpacked the mod file and used ls, and then searched through for mcmeta, etc)
Working on the Python. Like I said, I'll use diff on the blocks id lists between 31 and 24 to see what I need to add. I'll ask here if I need anything.

[HubTou]

To clarify, I meant that any block in my render that was supposed to be from LOTR was replaced by some block from 1.8 (for example, we had roads made of dark oak fences, instead of gondor brick). I assume this means that 1.8 stuff was supported by the version of the overviewer that I was using, so I'm wondering if you could find a specific commit on the overviewer repo to use for this tool (A solid, stable 1.7.10 version of the overviewer). Does that make any more sense?

Ahhhh, OK :-)

Yes, I think we should use the 0.11 versions which were made for Minecraft 1.7.x.
Specifically, I used the source code from the 8881ba6 commit, but I think we can use others before September 2, 2014.

Commit 50b8da5 from August 31, 2014, seems to be the last one of the 0.11 versions. Here's its download link.