Skip to content

Commit 7c9a7cb

Browse files
committed
chore: renaming dto and revise changelog
1 parent a4206dd commit 7c9a7cb

File tree

8 files changed

+15
-15
lines changed

8 files changed

+15
-15
lines changed

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ This changelog follows the principles of [Keep a Changelog](https://keepachangel
99
### Added
1010

1111
- New Use Case: [Get Collections For Linking Use Case](./docs/useCases.md#get-collections-for-linking).
12-
- New Use Case: [Create a Template](./docs/useCases.md#create-a-template) under Collections.
12+
- New Use Case: [Create a Dataset Template](./docs/useCases.md#create-a-dataset-template) under Collections.
1313

1414
### Changed
1515

src/collections/domain/dtos/TemplateCreateDTO.ts renamed to src/collections/domain/dtos/CreateDatasetTemplateDTO.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { MetadataFieldTypeClass } from '../../../metadataBlocks/domain/models/MetadataBlock'
22

3-
export interface TemplateCreateDTO {
3+
export interface CreateDatasetTemplateDTO {
44
name: string
55
isDefault?: boolean
66
fields?: TemplateFieldDTO[]

src/collections/domain/repositories/ICollectionsRepository.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ import { CollectionItemType } from '../../../collections/domain/models/Collectio
1212
import { CollectionLinks } from '../models/CollectionLinks'
1313
import { CollectionSummary } from '../models/CollectionSummary'
1414
import { LinkingObjectType } from '../useCases/GetCollectionsForLinking'
15-
import { TemplateCreateDTO } from '../dtos/TemplateCreateDTO'
15+
import { CreateDatasetTemplateDTO } from '../dtos/CreateDatasetTemplateDTO'
1616

1717
export interface ICollectionsRepository {
1818
getCollection(collectionIdOrAlias: number | string): Promise<Collection>
@@ -71,6 +71,6 @@ export interface ICollectionsRepository {
7171
): Promise<CollectionSummary[]>
7272
createDatasetTemplate(
7373
collectionIdOrAlias: number | string,
74-
template: TemplateCreateDTO
74+
template: CreateDatasetTemplateDTO
7575
): Promise<void>
7676
}

src/collections/domain/useCases/CreateDatasetTemplate.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { ROOT_COLLECTION_ID } from '../models/Collection'
22
import { UseCase } from '../../../core/domain/useCases/UseCase'
33
import { ICollectionsRepository } from '../repositories/ICollectionsRepository'
4-
import { TemplateCreateDTO } from '../dtos/TemplateCreateDTO'
4+
import { CreateDatasetTemplateDTO } from '../dtos/CreateDatasetTemplateDTO'
55

66
export class CreateDatasetTemplate implements UseCase<void> {
77
private collectionsRepository: ICollectionsRepository
@@ -13,13 +13,13 @@ export class CreateDatasetTemplate implements UseCase<void> {
1313
/**
1414
* Creates a Dataset Template in the specified collection.
1515
*
16-
* @param {TemplateCreateDTO} template - Template definition payload.
16+
* @param {CreateDatasetTemplateDTO} template - Template definition payload.
1717
* @param {number | string} [collectionIdOrAlias = ':root'] - A generic collection identifier, which can be either a string (for queries by CollectionAlias), or a number (for queries by CollectionId)
1818
* If this parameter is not set, the default value is: ':root'.
1919
* @returns {Promise<void>}
2020
*/
2121
async execute(
22-
template: TemplateCreateDTO,
22+
template: CreateDatasetTemplateDTO,
2323
collectionIdOrAlias: number | string = ROOT_COLLECTION_ID
2424
): Promise<void> {
2525
return await this.collectionsRepository.createDatasetTemplate(collectionIdOrAlias, template)

src/collections/infra/repositories/CollectionsRepository.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ import { ReadError } from '../../../core/domain/repositories/ReadError'
4040
import { CollectionLinks } from '../../domain/models/CollectionLinks'
4141
import { CollectionSummary } from '../../domain/models/CollectionSummary'
4242
import { LinkingObjectType } from '../../domain/useCases/GetCollectionsForLinking'
43-
import { TemplateCreateDTO } from '../../domain/dtos/TemplateCreateDTO'
43+
import { CreateDatasetTemplateDTO } from '../../domain/dtos/CreateDatasetTemplateDTO'
4444

4545
export interface NewCollectionRequestPayload {
4646
alias: string
@@ -532,7 +532,7 @@ export class CollectionsRepository extends ApiRepository implements ICollections
532532

533533
public async createDatasetTemplate(
534534
collectionIdOrAlias: number | string,
535-
template: TemplateCreateDTO
535+
template: CreateDatasetTemplateDTO
536536
): Promise<void> {
537537
return this.doPost(
538538
`/${this.collectionsResourceName}/${collectionIdOrAlias}/templates`,

test/functional/collections/createDatasetTemplate.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import { ApiConfig } from '../../../src'
22
import { DataverseApiAuthMechanism } from '../../../src/core/infra/repositories/ApiConfig'
33
import { TestConstants } from '../../testHelpers/TestConstants'
44
import { getDatasetTemplates } from '../../../src/datasets'
5-
import { TemplateCreateDTO } from '../../../src/collections/domain/dtos/TemplateCreateDTO'
5+
import { CreateDatasetTemplateDTO } from '../../../src/collections/domain/dtos/CreateDatasetTemplateDTO'
66
import { createDatasetTemplate } from '../../../src/collections'
77
import { MetadataFieldTypeClass } from '../../../src/metadataBlocks/domain/models/MetadataBlock'
88
import { deleteDatasetTemplateViaApi } from '../../testHelpers/datasets/datasetTemplatesHelper'
@@ -17,7 +17,7 @@ describe('CreateTemplate.execute', () => {
1717
})
1818

1919
test('should create a template in :root with provided JSON', async () => {
20-
const templateDto: TemplateCreateDTO = {
20+
const templateDto: CreateDatasetTemplateDTO = {
2121
name: 'TestDataverse template',
2222
isDefault: true,
2323
fields: [

test/integration/collections/CollectionsRepository.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ import {
6060
DvObjectFeaturedItemDTO,
6161
FeaturedItemsDTO
6262
} from '../../../src/collections/domain/dtos/FeaturedItemsDTO'
63-
import { TemplateCreateDTO } from '../../../src/collections/domain/dtos/TemplateCreateDTO'
63+
import { CreateDatasetTemplateDTO } from '../../../src/collections/domain/dtos/CreateDatasetTemplateDTO'
6464
import { getDatasetTemplates } from '../../../src/datasets'
6565
import { deleteDatasetTemplateViaApi } from '../../testHelpers/datasets/datasetTemplatesHelper'
6666

@@ -2150,7 +2150,7 @@ describe('CollectionsRepository', () => {
21502150
})
21512151

21522152
describe('createDatasetTemplate', () => {
2153-
const templateDto: TemplateCreateDTO = {
2153+
const templateDto: CreateDatasetTemplateDTO = {
21542154
name: 'CollectionsRepository template',
21552155
isDefault: true,
21562156
fields: [

test/unit/collections/createDatasetTemplate.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
import { CreateDatasetTemplate } from '../../../src/collections/domain/useCases/CreateDatasetTemplate'
22
import { ICollectionsRepository } from '../../../src/collections/domain/repositories/ICollectionsRepository'
3-
import { TemplateCreateDTO } from '../../../src/collections/domain/dtos/TemplateCreateDTO'
3+
import { CreateDatasetTemplateDTO } from '../../../src/collections/domain/dtos/CreateDatasetTemplateDTO'
44
import { WriteError } from '../../../src'
55

66
describe('execute', () => {
7-
const testTemplateDTO = { name: 't' } as TemplateCreateDTO
7+
const testTemplateDTO = { name: 't' } as CreateDatasetTemplateDTO
88
const testCollectionId = 1
99

1010
test('should return undefined when repository call is successful', async () => {

0 commit comments

Comments
 (0)