From 2e7c5a98c120fafe84bbafb8c6e2757b975658c3 Mon Sep 17 00:00:00 2001 From: Cheng Shi Date: Thu, 3 Apr 2025 17:07:48 -0400 Subject: [PATCH 1/3] fix: change the modal of termsOfAccess --- src/datasets/domain/models/DatasetVersionDiff.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/datasets/domain/models/DatasetVersionDiff.ts b/src/datasets/domain/models/DatasetVersionDiff.ts index 2a8b32ff..d5091b57 100644 --- a/src/datasets/domain/models/DatasetVersionDiff.ts +++ b/src/datasets/domain/models/DatasetVersionDiff.ts @@ -8,7 +8,9 @@ export interface DatasetVersionDiff { filesRemoved?: FileSummary[] fileChanges?: FileDiff[] filesReplaced?: FileReplacement[] - termsOfAccess?: FieldDiff[] + termsOfAccess?: { + changed: FieldDiff[] + } } export interface FileSummary { From d6eb0c37cab73510ceb7c3d06d9cc93e711287a2 Mon Sep 17 00:00:00 2001 From: Cheng Shi Date: Thu, 3 Apr 2025 17:14:46 -0400 Subject: [PATCH 2/3] fix: unit test helper of termsOfAccess --- test/testHelpers/datasets/datasetVersionDiffHelper.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/testHelpers/datasets/datasetVersionDiffHelper.ts b/test/testHelpers/datasets/datasetVersionDiffHelper.ts index fe99338f..9dc7f504 100644 --- a/test/testHelpers/datasets/datasetVersionDiffHelper.ts +++ b/test/testHelpers/datasets/datasetVersionDiffHelper.ts @@ -74,6 +74,6 @@ export const createDatasetVersionDiff = (): DatasetVersionDiff => { filesRemoved: [fileSummary], fileChanges: [fileDiff], filesReplaced: [fileReplacement], - termsOfAccess: [fieldDiff] + termsOfAccess: { changed: [fieldDiff] } } } From 74a0660d39d9b9a55c8360e673e7c410f51ee13a Mon Sep 17 00:00:00 2001 From: Cheng Shi Date: Thu, 3 Apr 2025 18:16:11 -0400 Subject: [PATCH 3/3] fix: add payload --- .../repositories/transformers/DatasetVersionDiffPayload.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/datasets/infra/repositories/transformers/DatasetVersionDiffPayload.ts b/src/datasets/infra/repositories/transformers/DatasetVersionDiffPayload.ts index b9016732..61ff48b1 100644 --- a/src/datasets/infra/repositories/transformers/DatasetVersionDiffPayload.ts +++ b/src/datasets/infra/repositories/transformers/DatasetVersionDiffPayload.ts @@ -6,7 +6,7 @@ export interface DatasetVersionDiffPayload { filesRemoved: FileSummaryPayload[] fileChanges: FileDiffPayload[] filesReplaced: FileReplacementPayload[] - TermsOfAccess: FieldDiffPayload[] + TermsOfAccess: { changed: FieldDiffPayload[] } } export interface FileSummaryPayload {